]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
net: vxlan: delete redundant judgment statements
authorLi Zetao <lizetao1@huawei.com>
Thu, 22 Aug 2024 04:32:43 +0000 (12:32 +0800)
committerDavid S. Miller <davem@davemloft.net>
Fri, 23 Aug 2024 13:27:44 +0000 (14:27 +0100)
The initial value of err is -ENOBUFS, and err is guaranteed to be
less than 0 before all goto errout. Therefore, on the error path
of errout, there is no need to repeatedly judge that err is less than 0,
and delete redundant judgments to make the code more concise.

Signed-off-by: Li Zetao <lizetao1@huawei.com>
Reviewed-by: Petr Machata <petrm@nvidia.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/vxlan/vxlan_core.c

index 8983e75e9881d471fb5011b7d1636f7d6f519875..34391c18bba7e93181b7819b9dbfd44fb69cd82d 100644 (file)
@@ -277,8 +277,7 @@ static void __vxlan_fdb_notify(struct vxlan_dev *vxlan, struct vxlan_fdb *fdb,
        rtnl_notify(skb, net, 0, RTNLGRP_NEIGH, NULL, GFP_ATOMIC);
        return;
 errout:
-       if (err < 0)
-               rtnl_set_sk_err(net, RTNLGRP_NEIGH, err);
+       rtnl_set_sk_err(net, RTNLGRP_NEIGH, err);
 }
 
 static void vxlan_fdb_switchdev_notifier_info(const struct vxlan_dev *vxlan,