]> git.ipfire.org Git - thirdparty/dovecot/core.git/commitdiff
lib: istream-sized - remove explicit i_error() logging
authorTimo Sirainen <timo.sirainen@dovecot.fi>
Fri, 23 Dec 2016 17:26:17 +0000 (12:26 -0500)
committerTimo Sirainen <timo.sirainen@dovecot.fi>
Thu, 23 Feb 2017 10:44:58 +0000 (12:44 +0200)
The stream_errno is set, so it's the caller's responsibility to log the
error. There's no need to log it twice.

src/lib/istream-sized.c

index b9c0164868b0e716e80e04d5141a51e36a7a7229..eb1b13622fd7c262654e135268fe4e28b171224e 100644 (file)
@@ -90,9 +90,6 @@ static ssize_t i_stream_sized_read(struct istream_private *stream)
        else if (pos > left) {
                error = sstream->error_callback(&data, sstream->error_context);
                io_stream_set_error(&stream->iostream, "%s", error);
-               i_error("read(%s) failed: %s",
-                       i_stream_get_name(&stream->istream),
-                       stream->iostream.error);
                pos = left;
                stream->istream.eof = TRUE;
                stream->istream.stream_errno = EINVAL;
@@ -104,9 +101,6 @@ static ssize_t i_stream_sized_read(struct istream_private *stream)
        } else {
                error = sstream->error_callback(&data, sstream->error_context);
                io_stream_set_error(&stream->iostream, "%s", error);
-               i_error("read(%s) failed: %s",
-                       i_stream_get_name(&stream->istream),
-                       stream->iostream.error);
                stream->istream.stream_errno = EINVAL;
        }