]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
usb: gadget: midi2: Reverse-select at the right place
authorTakashi Iwai <tiwai@suse.de>
Wed, 1 Jan 2025 13:11:19 +0000 (14:11 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 7 Jan 2025 10:42:22 +0000 (11:42 +0100)
We should do reverse selection of other components from
CONFIG_USB_F_MIDI2 which is tristate, instead of
CONFIG_USB_CONFIGFS_F_MIDI2 which is bool, for satisfying subtle
module dependencies.

Fixes: 8b645922b223 ("usb: gadget: Add support for USB MIDI 2.0 function driver")
Cc: stable <stable@kernel.org>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Link: https://lore.kernel.org/r/20250101131124.27599-1-tiwai@suse.de
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/usb/gadget/Kconfig

index 566ff0b1282a82950b0af3c020261d83a6d21579..76521555e3c14c29aa09f448168a6affc6bfa02a 100644 (file)
@@ -211,6 +211,8 @@ config USB_F_MIDI
 
 config USB_F_MIDI2
        tristate
+       select SND_UMP
+       select SND_UMP_LEGACY_RAWMIDI
 
 config USB_F_HID
        tristate
@@ -445,8 +447,6 @@ config USB_CONFIGFS_F_MIDI2
        depends on USB_CONFIGFS
        depends on SND
        select USB_LIBCOMPOSITE
-       select SND_UMP
-       select SND_UMP_LEGACY_RAWMIDI
        select USB_F_MIDI2
        help
          The MIDI 2.0 function driver provides the generic emulated