]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
drm/amd/display: use swap() in update_phy_id_mapping()
authorJiapeng Chong <jiapeng.chong@linux.alibaba.com>
Thu, 12 Dec 2024 01:47:17 +0000 (09:47 +0800)
committerAlex Deucher <alexander.deucher@amd.com>
Wed, 18 Dec 2024 17:16:30 +0000 (12:16 -0500)
Use existing swap() function rather than duplicating its implementation.

./drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_crc.c:185:47-48: WARNING opportunity for swap().
./drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_crc.c:125:53-54: WARNING opportunity for swap().

Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=12335
Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_crc.c

index 309c7999faa6fd1ebf09cb8a379aa2189242ea2d..6fdc306a4a86bbbfcca21cb090311539791f6c6b 100644 (file)
@@ -120,11 +120,8 @@ static void update_phy_id_mapping(struct amdgpu_device *adev)
        for (idx = connector_cnt; idx > 1 ; idx--) {
                for (idx_2 = 0; idx_2 < (idx - 1); idx_2++) {
                        if (sort_connector[idx_2]->dc_link->link_enc_hw_inst >
-                               sort_connector[idx_2 + 1]->dc_link->link_enc_hw_inst) {
-                               aconnector = sort_connector[idx_2];
-                               sort_connector[idx_2] = sort_connector[idx_2 + 1];
-                               sort_connector[idx_2 + 1] = aconnector;
-                       }
+                           sort_connector[idx_2 + 1]->dc_link->link_enc_hw_inst)
+                               swap(sort_connector[idx_2], sort_connector[idx_2 + 1]);
                }
        }
 
@@ -180,11 +177,8 @@ static void update_phy_id_mapping(struct amdgpu_device *adev)
                                                }
                                        }
 
-                                       if (swap) {
-                                               aconnector = sort_connector[j];
-                                               sort_connector[j] = sort_connector[j + 1];
-                                               sort_connector[j + 1] = aconnector;
-                                       }
+                                       if (swap)
+                                               swap(sort_connector[j], sort_connector[j + 1]);
                                }
                        }