iommu: Allow attaching static domains in iommu_attach_device_pasid()

The idxd driver attaches the default domain to a PASID of the device to
perform kernel DMA using that PASID. The domain is attached to the
device's PASID through iommu_attach_device_pasid(), which checks if the
domain->owner matches the iommu_ops retrieved from the device. If they
do not match, it returns a failure.

        if (ops != domain->owner || pasid == IOMMU_NO_PASID)
                return -EINVAL;

The static identity domain implemented by the intel iommu driver doesn't
specify the domain owner. Therefore, kernel DMA with PASID doesn't work
for the idxd driver if the device translation mode is set to passthrough.

Generally the owner field of static domains are not set because they are
already part of iommu ops. Add a helper domain_iommu_ops_compatible()
that checks if a domain is compatible with the device's iommu ops. This
helper explicitly allows the static blocked and identity domains associated
with the device's iommu_ops to be considered compatible.

Fixes: 2031c469f816 ("iommu/vt-d: Add support for static identity domain")
Closes: https://bugzilla.kernel.org/show_bug.cgi?id=220031
Cc: stable@vger.kernel.org
Suggested-by: Jason Gunthorpe <jgg@nvidia.com>
Link: https://lore.kernel.org/linux-iommu/20250422191554.GC1213339@ziepe.ca/
Signed-off-by: Lu Baolu <baolu.lu@linux.intel.com>
Reviewed-by: Dave Jiang <dave.jiang@intel.com>
Reviewed-by: Robin Murphy <robin.murphy@arm.com>
Reviewed-by: Jason Gunthorpe <jgg@nvidia.com>
Reviewed-by: Vasant Hegde <vasant.hegde@amd.com>
Reviewed-by: Kevin Tian <kevin.tian@intel.com>
Link: https://lore.kernel.org/r/20250424034123.2311362-1-baolu.lu@linux.intel.com
Signed-off-by: Joerg Roedel <jroedel@suse.de>

diff --git a/drivers/iommu/iommu.c b/drivers/iommu/iommu.c
index 3e4a9fe867f510231edf23fcc4e805e53a28bfae..f257ca30ed482a59e5878dc2938654a2b099e8ce 100644 (file)
--- a/drivers/iommu/iommu.c
+++ b/drivers/iommu/iommu.c
@@ -2206,6 +2206,19 @@ static void *iommu_make_pasid_array_entry(struct iommu_domain *domain,
        return xa_tag_pointer(domain, IOMMU_PASID_ARRAY_DOMAIN);
 }
 
+static bool domain_iommu_ops_compatible(const struct iommu_ops *ops,
+                                       struct iommu_domain *domain)
+{
+       if (domain->owner == ops)
+               return true;
+
+       /* For static domains, owner isn't set. */
+       if (domain == ops->blocked_domain || domain == ops->identity_domain)
+               return true;
+
+       return false;
+}
+
 static int __iommu_attach_group(struct iommu_domain *domain,
                                struct iommu_group *group)
 {
@@ -2216,7 +2229,8 @@ static int __iommu_attach_group(struct iommu_domain *domain,
                return -EBUSY;
 
        dev = iommu_group_first_dev(group);
-       if (!dev_has_iommu(dev) || dev_iommu_ops(dev) != domain->owner)
+       if (!dev_has_iommu(dev) ||
+           !domain_iommu_ops_compatible(dev_iommu_ops(dev), domain))
                return -EINVAL;
 
        return __iommu_group_set_domain(group, domain);
@@ -3405,7 +3419,8 @@ int iommu_attach_device_pasid(struct iommu_domain *domain,
            !ops->blocked_domain->ops->set_dev_pasid)
                return -EOPNOTSUPP;
 
-       if (ops != domain->owner || pasid == IOMMU_NO_PASID)
+       if (!domain_iommu_ops_compatible(ops, domain) ||
+           pasid == IOMMU_NO_PASID)
                return -EINVAL;
 
        mutex_lock(&group->mutex);
@@ -3481,7 +3496,7 @@ int iommu_replace_device_pasid(struct iommu_domain *domain,
        if (!domain->ops->set_dev_pasid)
                return -EOPNOTSUPP;
 
-       if (dev_iommu_ops(dev) != domain->owner ||
+       if (!domain_iommu_ops_compatible(dev_iommu_ops(dev), domain) ||
            pasid == IOMMU_NO_PASID || !handle)
                return -EINVAL;