]> git.ipfire.org Git - thirdparty/glibc.git/commitdiff
Add sysdeps/ieee754/soft-fp.
authorJoseph Myers <joseph@codesourcery.com>
Tue, 12 Dec 2017 23:34:05 +0000 (23:34 +0000)
committerJoseph Myers <joseph@codesourcery.com>
Tue, 12 Dec 2017 23:35:21 +0000 (23:35 +0000)
The default sysdeps/ieee754 fma implementations rely on exceptions and
rounding modes to achieve correct results through internal use of
round-to-odd.  Thus, glibc configurations without support for
exceptions and rounding modes instead need to use implementations of
fma based on soft-fp.

At present, this is achieved via having implementation files in
soft-fp/ that are #included by sysdeps files for each glibc
configuration that needs them.  In general this means such a
configuration has its own s_fma.c and s_fmaf.c.

TS 18661-1 adds functions that do an operation (+ - * / sqrt fma) on
arguments wider than the return type, with a single rounding of the
infinite-precision result to that return type.  These are also
naturally implemented using round-to-odd on platforms with hardware
support for rounding modes and exceptions but lacking hardware support
for these narrowing operations themselves.  (Platforms that have
direct hardware support for such narrowing operations include at least
ia64, and Power ISA 2.07 or later, which I think means POWER8 or
later.)

So adding the remaining TS 18661-1 functions would mean at least six
narrowing function implementations (fadd fsub fmul fdiv ffma fsqrt),
with aliases for other types and further implementations in some
configurations, that need to be overridden for configurations lacking
hardware exceptions and rounding modes.  Requiring all such
configurations (currently seven of them) to have their own source
files for all those functions seems undesirable.

Thus, this patch adds a directory sysdeps/ieee754/soft-fp to contain
libm function implementations based on soft-fp.  This directory is
then used via Implies from all the configurations that need it, so no
more files need adding to every such configuration when adding more
functions with soft-fp implementations.  A configuration can still
selectively #include a particular file from this directory if desired;
thus, the MIPS #include of the fmal implementation is retained, since
that's appropriate even for hard float (because long double is always
implementated in software for MIPS64, so the soft-fp implementation of
fmal is better than the ldbl-128 one).

This also provides additional motivation for my recent patch removing
--with-fp / --without-fp: previously there was no need for correct use
of --without-fp for no-FPU ARM or SH3, and now we have autodetection
nofpu/ sysdeps directories can be used by this patch for those
configurations without imposing any new requirements on how glibc is
configured.

(The mips64/*/fpu/s_fma.c files added by this patch are needed to keep
the dbl-64 version of fma for double, rather than the ldbl-128 one,
used in that case.)

Tested with build-many-glibcs.py that installed stripped shared
libraries are unchanged by this patch.

* soft-fp/fmadf4.c: Move to ....
* sysdeps/ieee754/soft-fp/s_fma.c: ... here.
* soft-fp/fmasf4.c: Move to ....
* sysdeps/ieee754/soft-fp/s_fmaf.c: ... here.
* soft-fp/fmatf4.c: Move to ....
* sysdeps/ieee754/soft-fp/s_fmal.c: ... here.
* sysdeps/ieee754/soft-fp/Makefile: New file.
* sysdeps/arm/preconfigure.ac: Define with_fp_cond.
* sysdeps/arm/preconfigure: Regenerated.
* sysdeps/arm/nofpu/Implies: New file.
* sysdeps/arm/s_fma.c: Remove file.
* sysdeps/arm/s_fmaf.c: Likewise.
* sysdeps/m68k/coldfire/nofpu/Implies: New file.
* sysdeps/m68k/coldfire/nofpu/s_fma.c: Remove file.
* sysdeps/m68k/coldfire/nofpu/s_fmaf.c: Likewise.
* sysdeps/microblaze/Implies: Add ieee754/soft-fp.
* sysdeps/microblaze/s_fma.c: Remove file.
* sysdeps/microblaze/s_fmaf.c: Likewise.
* sysdeps/mips/mips32/nofpu/Implies: New file.
* sysdeps/mips/mips64/n32/fpu/s_fma.c: Likewise.
* sysdeps/mips/mips64/n32/nofpu/Implies: Likewise.
* sysdeps/mips/mips64/n64/fpu/s_fma.c: Likewise.
* sysdeps/mips/mips64/n64/nofpu/Implies: Likewise.
* sysdeps/mips/ieee754/s_fma.c: Remove file.
* sysdeps/mips/ieee754/s_fmaf.c: Likewise.
* sysdeps/mips/ieee754/s_fmal.c: Update include for move of fmal
implementation.
* sysdeps/nios2/Implies: Add ieee754/soft-fp.
* sysdeps/nios2/s_fma.c: Remove file.
* sysdeps/nios2/s_fmaf.c: Likewise.
* sysdeps/sh/nofpu/Implies: New file.
* sysdeps/sh/s_fma.c: Remove file.
* sysdeps/sh/s_fmaf.c: Likewise.
* sysdeps/tile/Implies: Add ieee754/soft-fp.
* sysdeps/tile/s_fma.c: Remove file.
* sysdeps/tile/s_fmaf.c: Likewise.

33 files changed:
ChangeLog
sysdeps/arm/nofpu/Implies [new file with mode: 0644]
sysdeps/arm/preconfigure
sysdeps/arm/preconfigure.ac
sysdeps/arm/s_fma.c [deleted file]
sysdeps/arm/s_fmaf.c [deleted file]
sysdeps/ieee754/soft-fp/Makefile [new file with mode: 0644]
sysdeps/ieee754/soft-fp/s_fma.c [moved from soft-fp/fmadf4.c with 100% similarity]
sysdeps/ieee754/soft-fp/s_fmaf.c [moved from soft-fp/fmasf4.c with 100% similarity]
sysdeps/ieee754/soft-fp/s_fmal.c [moved from soft-fp/fmatf4.c with 100% similarity]
sysdeps/m68k/coldfire/nofpu/Implies [new file with mode: 0644]
sysdeps/m68k/coldfire/nofpu/s_fma.c [deleted file]
sysdeps/m68k/coldfire/nofpu/s_fmaf.c [deleted file]
sysdeps/microblaze/Implies
sysdeps/microblaze/s_fma.c [deleted file]
sysdeps/microblaze/s_fmaf.c [deleted file]
sysdeps/mips/ieee754/s_fma.c [deleted file]
sysdeps/mips/ieee754/s_fmaf.c [deleted file]
sysdeps/mips/ieee754/s_fmal.c
sysdeps/mips/mips32/nofpu/Implies [new file with mode: 0644]
sysdeps/mips/mips64/n32/fpu/s_fma.c [new file with mode: 0644]
sysdeps/mips/mips64/n32/nofpu/Implies [new file with mode: 0644]
sysdeps/mips/mips64/n64/fpu/s_fma.c [new file with mode: 0644]
sysdeps/mips/mips64/n64/nofpu/Implies [new file with mode: 0644]
sysdeps/nios2/Implies
sysdeps/nios2/s_fma.c [deleted file]
sysdeps/nios2/s_fmaf.c [deleted file]
sysdeps/sh/nofpu/Implies [new file with mode: 0644]
sysdeps/sh/s_fma.c [deleted file]
sysdeps/sh/s_fmaf.c [deleted file]
sysdeps/tile/Implies
sysdeps/tile/s_fma.c [deleted file]
sysdeps/tile/s_fmaf.c [deleted file]

index 2ceae53f87f2847d0c4d0a91ddb292c3a8062051..f560b2a832593f3116781b508cc7842db6ca0c03 100644 (file)
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,42 @@
+2017-12-12  Joseph Myers  <joseph@codesourcery.com>
+
+       * soft-fp/fmadf4.c: Move to ....
+       * sysdeps/ieee754/soft-fp/s_fma.c: ... here.
+       * soft-fp/fmasf4.c: Move to ....
+       * sysdeps/ieee754/soft-fp/s_fmaf.c: ... here.
+       * soft-fp/fmatf4.c: Move to ....
+       * sysdeps/ieee754/soft-fp/s_fmal.c: ... here.
+       * sysdeps/ieee754/soft-fp/Makefile: New file.
+       * sysdeps/arm/preconfigure.ac: Define with_fp_cond.
+       * sysdeps/arm/preconfigure: Regenerated.
+       * sysdeps/arm/nofpu/Implies: New file.
+       * sysdeps/arm/s_fma.c: Remove file.
+       * sysdeps/arm/s_fmaf.c: Likewise.
+       * sysdeps/m68k/coldfire/nofpu/Implies: New file.
+       * sysdeps/m68k/coldfire/nofpu/s_fma.c: Remove file.
+       * sysdeps/m68k/coldfire/nofpu/s_fmaf.c: Likewise.
+       * sysdeps/microblaze/Implies: Add ieee754/soft-fp.
+       * sysdeps/microblaze/s_fma.c: Remove file.
+       * sysdeps/microblaze/s_fmaf.c: Likewise.
+       * sysdeps/mips/mips32/nofpu/Implies: New file.
+       * sysdeps/mips/mips64/n32/fpu/s_fma.c: Likewise.
+       * sysdeps/mips/mips64/n32/nofpu/Implies: Likewise.
+       * sysdeps/mips/mips64/n64/fpu/s_fma.c: Likewise.
+       * sysdeps/mips/mips64/n64/nofpu/Implies: Likewise.
+       * sysdeps/mips/ieee754/s_fma.c: Remove file.
+       * sysdeps/mips/ieee754/s_fmaf.c: Likewise.
+       * sysdeps/mips/ieee754/s_fmal.c: Update include for move of fmal
+       implementation.
+       * sysdeps/nios2/Implies: Add ieee754/soft-fp.
+       * sysdeps/nios2/s_fma.c: Remove file.
+       * sysdeps/nios2/s_fmaf.c: Likewise.
+       * sysdeps/sh/nofpu/Implies: New file.
+       * sysdeps/sh/s_fma.c: Remove file.
+       * sysdeps/sh/s_fmaf.c: Likewise.
+       * sysdeps/tile/Implies: Add ieee754/soft-fp.
+       * sysdeps/tile/s_fma.c: Remove file.
+       * sysdeps/tile/s_fmaf.c: Likewise.
+
 2017-12-12  H.J. Lu  <hongjiu.lu@intel.com>
 
        * sysdeps/x86_64/fpu/multiarch/Makefile (libm-sysdep_routines):
diff --git a/sysdeps/arm/nofpu/Implies b/sysdeps/arm/nofpu/Implies
new file mode 100644 (file)
index 0000000..abcbadb
--- /dev/null
@@ -0,0 +1 @@
+ieee754/soft-fp
index 33e9501c4fe19ac71a497b41562f0143e0783aaa..d803256d9fb2b276731a5f18d25dc1fed898bd06 100644 (file)
@@ -52,4 +52,5 @@ $as_echo "$as_me: WARNING: arm/preconfigure: Did not find ARM architecture type;
   esac
 
   machine=arm/$machine
+  with_fp_cond="!defined __SOFTFP__"
 esac
index 20de5bcfea0e378ea1eddd931a8892d47ec456eb..43d014031d0a701ea184a7fd6015ce2dd83d3ca1 100644 (file)
@@ -47,4 +47,5 @@ arm*)
   esac
 
   machine=arm/$machine
+  with_fp_cond="!defined __SOFTFP__"
 esac
diff --git a/sysdeps/arm/s_fma.c b/sysdeps/arm/s_fma.c
deleted file mode 100644 (file)
index dc4e27b..0000000
+++ /dev/null
@@ -1,5 +0,0 @@
-#ifdef __SOFTFP__
-# include <soft-fp/fmadf4.c>
-#else
-# include <sysdeps/ieee754/dbl-64/s_fma.c>
-#endif
diff --git a/sysdeps/arm/s_fmaf.c b/sysdeps/arm/s_fmaf.c
deleted file mode 100644 (file)
index 550d8b8..0000000
+++ /dev/null
@@ -1,5 +0,0 @@
-#ifdef __SOFTFP__
-# include <soft-fp/fmasf4.c>
-#else
-# include <sysdeps/ieee754/dbl-64/s_fmaf.c>
-#endif
diff --git a/sysdeps/ieee754/soft-fp/Makefile b/sysdeps/ieee754/soft-fp/Makefile
new file mode 100644 (file)
index 0000000..ada13e8
--- /dev/null
@@ -0,0 +1,3 @@
+ifeq ($(subdir),math)
+CPPFLAGS += -I../soft-fp
+endif
diff --git a/sysdeps/m68k/coldfire/nofpu/Implies b/sysdeps/m68k/coldfire/nofpu/Implies
new file mode 100644 (file)
index 0000000..abcbadb
--- /dev/null
@@ -0,0 +1 @@
+ieee754/soft-fp
diff --git a/sysdeps/m68k/coldfire/nofpu/s_fma.c b/sysdeps/m68k/coldfire/nofpu/s_fma.c
deleted file mode 100644 (file)
index d9613fa..0000000
+++ /dev/null
@@ -1 +0,0 @@
-#include <soft-fp/fmadf4.c>
diff --git a/sysdeps/m68k/coldfire/nofpu/s_fmaf.c b/sysdeps/m68k/coldfire/nofpu/s_fmaf.c
deleted file mode 100644 (file)
index aa5c9b2..0000000
+++ /dev/null
@@ -1 +0,0 @@
-#include <soft-fp/fmasf4.c>
index 73c766c52ec46340941ef8b617c0f6822c0e35da..746b21ad665bde810ef20cd6638a9617d2678860 100644 (file)
@@ -1,4 +1,5 @@
 wordsize-32
 # MicroBlaze uses IEEE 754 floating point.
+ieee754/soft-fp
 ieee754/flt-32
 ieee754/dbl-64
diff --git a/sysdeps/microblaze/s_fma.c b/sysdeps/microblaze/s_fma.c
deleted file mode 100644 (file)
index d9613fa..0000000
+++ /dev/null
@@ -1 +0,0 @@
-#include <soft-fp/fmadf4.c>
diff --git a/sysdeps/microblaze/s_fmaf.c b/sysdeps/microblaze/s_fmaf.c
deleted file mode 100644 (file)
index aa5c9b2..0000000
+++ /dev/null
@@ -1 +0,0 @@
-#include <soft-fp/fmasf4.c>
diff --git a/sysdeps/mips/ieee754/s_fma.c b/sysdeps/mips/ieee754/s_fma.c
deleted file mode 100644 (file)
index 5741414..0000000
+++ /dev/null
@@ -1,5 +0,0 @@
-#ifdef __mips_hard_float
-# include <sysdeps/ieee754/dbl-64/s_fma.c>
-#else
-# include <soft-fp/fmadf4.c>
-#endif
diff --git a/sysdeps/mips/ieee754/s_fmaf.c b/sysdeps/mips/ieee754/s_fmaf.c
deleted file mode 100644 (file)
index 30bcdae..0000000
+++ /dev/null
@@ -1,5 +0,0 @@
-#ifdef __mips_hard_float
-# include <sysdeps/ieee754/dbl-64/s_fmaf.c>
-#else
-# include <soft-fp/fmasf4.c>
-#endif
index 6b83e914fe29604a23593557bd71b2c02ff87ea3..c52331967d125ff77ee22b96b67c81319f03d935 100644 (file)
@@ -4,4 +4,4 @@
 # error "long double fma being compiled for o32 ABI"
 #endif
 
-#include <soft-fp/fmatf4.c>
+#include <sysdeps/ieee754/soft-fp/s_fmal.c>
diff --git a/sysdeps/mips/mips32/nofpu/Implies b/sysdeps/mips/mips32/nofpu/Implies
new file mode 100644 (file)
index 0000000..abcbadb
--- /dev/null
@@ -0,0 +1 @@
+ieee754/soft-fp
diff --git a/sysdeps/mips/mips64/n32/fpu/s_fma.c b/sysdeps/mips/mips64/n32/fpu/s_fma.c
new file mode 100644 (file)
index 0000000..b61fa64
--- /dev/null
@@ -0,0 +1 @@
+#include <sysdeps/ieee754/dbl-64/s_fma.c>
diff --git a/sysdeps/mips/mips64/n32/nofpu/Implies b/sysdeps/mips/mips64/n32/nofpu/Implies
new file mode 100644 (file)
index 0000000..abcbadb
--- /dev/null
@@ -0,0 +1 @@
+ieee754/soft-fp
diff --git a/sysdeps/mips/mips64/n64/fpu/s_fma.c b/sysdeps/mips/mips64/n64/fpu/s_fma.c
new file mode 100644 (file)
index 0000000..b61fa64
--- /dev/null
@@ -0,0 +1 @@
+#include <sysdeps/ieee754/dbl-64/s_fma.c>
diff --git a/sysdeps/mips/mips64/n64/nofpu/Implies b/sysdeps/mips/mips64/n64/nofpu/Implies
new file mode 100644 (file)
index 0000000..abcbadb
--- /dev/null
@@ -0,0 +1 @@
+ieee754/soft-fp
index 387a0ca0520458343a6e689eee2a5854e096f91d..7d69983412d8a27d2479027b5a0fb4ef5e16d6e8 100644 (file)
@@ -1,3 +1,4 @@
 wordsize-32
+ieee754/soft-fp
 ieee754/dbl-64
 ieee754/flt-32
diff --git a/sysdeps/nios2/s_fma.c b/sysdeps/nios2/s_fma.c
deleted file mode 100644 (file)
index d9613fa..0000000
+++ /dev/null
@@ -1 +0,0 @@
-#include <soft-fp/fmadf4.c>
diff --git a/sysdeps/nios2/s_fmaf.c b/sysdeps/nios2/s_fmaf.c
deleted file mode 100644 (file)
index aa5c9b2..0000000
+++ /dev/null
@@ -1 +0,0 @@
-#include <soft-fp/fmasf4.c>
diff --git a/sysdeps/sh/nofpu/Implies b/sysdeps/sh/nofpu/Implies
new file mode 100644 (file)
index 0000000..abcbadb
--- /dev/null
@@ -0,0 +1 @@
+ieee754/soft-fp
diff --git a/sysdeps/sh/s_fma.c b/sysdeps/sh/s_fma.c
deleted file mode 100644 (file)
index d92438d..0000000
+++ /dev/null
@@ -1,5 +0,0 @@
-#ifdef __SH_FPU_ANY__
-# include <sysdeps/ieee754/dbl-64/s_fma.c>
-#else
-# include <soft-fp/fmadf4.c>
-#endif
diff --git a/sysdeps/sh/s_fmaf.c b/sysdeps/sh/s_fmaf.c
deleted file mode 100644 (file)
index 3b811ae..0000000
+++ /dev/null
@@ -1,5 +0,0 @@
-#ifdef __SH_FPU_ANY__
-# include <sysdeps/ieee754/dbl-64/s_fmaf.c>
-#else
-# include <soft-fp/fmasf4.c>
-#endif
index 5b29b261286b3199f9bb18b3e6f825d86d4fe453..1cbc0539050494c3baec19e0b9b6bdc64ac1c9f4 100644 (file)
@@ -1,2 +1,3 @@
+ieee754/soft-fp
 ieee754/dbl-64
 ieee754/flt-32
diff --git a/sysdeps/tile/s_fma.c b/sysdeps/tile/s_fma.c
deleted file mode 100644 (file)
index d9613fa..0000000
+++ /dev/null
@@ -1 +0,0 @@
-#include <soft-fp/fmadf4.c>
diff --git a/sysdeps/tile/s_fmaf.c b/sysdeps/tile/s_fmaf.c
deleted file mode 100644 (file)
index aa5c9b2..0000000
+++ /dev/null
@@ -1 +0,0 @@
-#include <soft-fp/fmasf4.c>