]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
btrfs: use extent_io_tree_panic() instead of BUG_ON()
authorFilipe Manana <fdmanana@suse.com>
Wed, 11 Mar 2026 12:35:33 +0000 (12:35 +0000)
committerDavid Sterba <dsterba@suse.com>
Tue, 7 Apr 2026 16:56:03 +0000 (18:56 +0200)
There's no need to call BUG_ON(), instead call extent_io_tree_panic(),
which also calls BUG(), but it prints an additional error message with
some useful information before hitting BUG().

Signed-off-by: Filipe Manana <fdmanana@suse.com>
Reviewed-by: David Sterba <dsterba@suse.com>
Signed-off-by: David Sterba <dsterba@suse.com>
fs/btrfs/extent-io-tree.c

index 5972fe28716e4af93d6b2608f9ed29bb7a10edf0..c2ede01f17622d0a0538afe11fcdd4df5a893101 100644 (file)
@@ -395,7 +395,8 @@ static void set_state_bits(struct extent_io_tree *tree,
                btrfs_set_delalloc_extent(tree->inode, state, bits);
 
        ret = add_extent_changeset(state, bits_to_set, changeset, 1);
-       BUG_ON(ret < 0);
+       if (unlikely(ret))
+               extent_io_tree_panic(tree, state, "add_extent_changeset", ret);
        state->state |= bits_to_set;
 }
 
@@ -567,7 +568,8 @@ static struct extent_state *clear_state_bit(struct extent_io_tree *tree,
                btrfs_clear_delalloc_extent(tree->inode, state, bits);
 
        ret = add_extent_changeset(state, bits_to_clear, changeset, 0);
-       BUG_ON(ret < 0);
+       if (unlikely(ret))
+               extent_io_tree_panic(tree, state, "add_extent_changeset", ret);
        state->state &= ~bits_to_clear;
        if (wake)
                wake_up(&state->wq);