]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
iommufd: Balance veventq->num_events inc/dec
authorYi Liu <yi.l.liu@intel.com>
Mon, 24 Mar 2025 12:00:34 +0000 (05:00 -0700)
committerJason Gunthorpe <jgg@nvidia.com>
Fri, 28 Mar 2025 13:07:23 +0000 (10:07 -0300)
iommufd_veventq_fops_read() decrements veventq->num_events when a vevent
is read out. However, the report path ony increments veventq->num_events
for normal events. To be balanced, make the read path decrement num_events
only for normal vevents.

Fixes: e36ba5ab808e ("iommufd: Add IOMMUFD_OBJ_VEVENTQ and IOMMUFD_CMD_VEVENTQ_ALLOC")
Link: https://patch.msgid.link/r/20250324120034.5940-3-yi.l.liu@intel.com
Signed-off-by: Yi Liu <yi.l.liu@intel.com>
Reviewed-by: Nicolin Chen <nicolinc@nvidia.com>
Tested-by: Nicolin Chen <nicolinc@nvidia.com>
Signed-off-by: Jason Gunthorpe <jgg@nvidia.com>
drivers/iommu/iommufd/eventq.c

index 4c43ace8c725d2bbfa0ebd69c6c85f7fd4ebbea3..f39cf079734769d02a24c6b9cddc982850ad33be 100644 (file)
@@ -385,7 +385,8 @@ static ssize_t iommufd_veventq_fops_read(struct file *filep, char __user *buf,
                        break;
                }
                spin_lock(&eventq->lock);
-               veventq->num_events--;
+               if (!vevent_for_lost_events_header(cur))
+                       veventq->num_events--;
                spin_unlock(&eventq->lock);
                done += cur->data_len;
                kfree(cur);