]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
media: camss: csiphy: Remove redundant dev_err call in msm_csiphy_subdev_init()
authorYang Yingliang <yangyingliang@huawei.com>
Thu, 1 Apr 2021 10:35:00 +0000 (12:35 +0200)
committerMauro Carvalho Chehab <mchehab+huawei@kernel.org>
Tue, 6 Apr 2021 14:09:50 +0000 (16:09 +0200)
There is an error message within devm_ioremap_resource
already, so remove the dev_err call to avoid redundant
error message.

Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
Reviewed-by: Robert Foss <robert.foss@linaro.org>
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
drivers/media/platform/qcom/camss/camss-csiphy.c

index 6ceb6d7d53d1ec58656ca1c62ba8908973a8aaac..b3c3bf19e522393ee3be0b4621ad1d6a1478b04f 100644 (file)
@@ -593,20 +593,16 @@ int msm_csiphy_subdev_init(struct camss *camss,
 
        r = platform_get_resource_byname(pdev, IORESOURCE_MEM, res->reg[0]);
        csiphy->base = devm_ioremap_resource(dev, r);
-       if (IS_ERR(csiphy->base)) {
-               dev_err(dev, "could not map memory\n");
+       if (IS_ERR(csiphy->base))
                return PTR_ERR(csiphy->base);
-       }
 
        if (camss->version == CAMSS_8x16 ||
            camss->version == CAMSS_8x96) {
                r = platform_get_resource_byname(pdev, IORESOURCE_MEM,
                                                 res->reg[1]);
                csiphy->base_clk_mux = devm_ioremap_resource(dev, r);
-               if (IS_ERR(csiphy->base_clk_mux)) {
-                       dev_err(dev, "could not map memory\n");
+               if (IS_ERR(csiphy->base_clk_mux))
                        return PTR_ERR(csiphy->base_clk_mux);
-               }
        } else {
                csiphy->base_clk_mux = NULL;
        }