]> git.ipfire.org Git - thirdparty/haproxy.git/commitdiff
BUG/MINOR: quic: Wrong RX packet reference counter usage
authorFrédéric Lécaille <flecaille@haproxy.com>
Fri, 4 Jun 2021 08:23:11 +0000 (10:23 +0200)
committerAmaury Denoyelle <adenoyelle@haproxy.com>
Thu, 23 Sep 2021 13:27:25 +0000 (15:27 +0200)
No need to call free_quic_rx_packet() after calling quic_rx_packet_eb64_delete()
as this latter already calls quic_rx_packet_refdec() also called by
free_quic_rx_packet().

src/xprt_quic.c

index cb00c02fdc1cb006db41f1ae761d89bc34cea6ba..074cc601c422587a4bc9d833cc160822791b5651 100644 (file)
@@ -2492,7 +2492,6 @@ int qc_treat_rx_pkts(struct quic_enc_level *el, struct quic_conn_ctx *ctx)
                                                    QUIC_EV_CONN_ELRXPKTS, ctx->conn);
                                        node = eb64_next(node);
                                        quic_rx_packet_eb64_delete(&pkt->pn_node);
-                                       free_quic_rx_packet(pkt);
                                        goto err;
                                }
 
@@ -2500,7 +2499,6 @@ int qc_treat_rx_pkts(struct quic_enc_level *el, struct quic_conn_ctx *ctx)
                }
                node = eb64_next(node);
                quic_rx_packet_eb64_delete(&pkt->pn_node);
-               free_quic_rx_packet(pkt);
        }
 
        if (!qc_treat_rx_crypto_frms(el, ctx))