]> git.ipfire.org Git - thirdparty/kmod.git/commitdiff
libkmod: explicitly return ENOMEM on kmod_module_*_new failure
authorEmil Velikov <emil.l.velikov@gmail.com>
Wed, 4 Jun 2025 16:16:25 +0000 (17:16 +0100)
committerLucas De Marchi <lucas.de.marchi@gmail.com>
Wed, 11 Jun 2025 13:03:26 +0000 (08:03 -0500)
All these functions do is malloc() the respective struct and initialize
the members. The errno can only be ENOMEM, so just return it directly.

Signed-off-by: Emil Velikov <emil.l.velikov@gmail.com>
Link: https://github.com/kmod-project/kmod/pull/368
Signed-off-by: Lucas De Marchi <lucas.de.marchi@gmail.com>
libkmod/libkmod-module.c

index 045822a407141a661eb9a3511e79cfdefb768228..229c6bca30c0956b4cd43ddd29d2610cbed6afa4 100644 (file)
@@ -2032,9 +2032,9 @@ KMOD_EXPORT int kmod_module_get_versions(const struct kmod_module *mod,
 
                mv = kmod_module_versions_new(versions[i].crc, versions[i].symbol);
                if (mv == NULL) {
-                       ret = -errno;
                        kmod_module_versions_free_list(*list);
                        *list = NULL;
+                       ret = -ENOMEM;
                        goto list_error;
                }
 
@@ -2133,9 +2133,9 @@ KMOD_EXPORT int kmod_module_get_symbols(const struct kmod_module *mod,
 
                mv = kmod_module_symbols_new(symbols[i].crc, symbols[i].symbol);
                if (mv == NULL) {
-                       ret = -errno;
                        kmod_module_symbols_free_list(*list);
                        *list = NULL;
+                       ret = -ENOMEM;
                        goto list_error;
                }
 
@@ -2240,9 +2240,9 @@ KMOD_EXPORT int kmod_module_get_dependency_symbols(const struct kmod_module *mod
                mv = kmod_module_dependency_symbols_new(symbols[i].crc, symbols[i].bind,
                                                        symbols[i].symbol);
                if (mv == NULL) {
-                       ret = -errno;
                        kmod_module_dependency_symbols_free_list(*list);
                        *list = NULL;
+                       ret = -ENOMEM;
                        goto list_error;
                }