Bug 1539849 - Multiple uplift request is not working as expected

diff --git a/extensions/BMO/template/en/default/hook/flag/type_comment-form.html.tmpl b/extensions/BMO/template/en/default/hook/flag/type_comment-form.html.tmpl
index 4cbe7df1744cb7d9e61d5e7f1cb24b8d8c8b370e..325cb84a48143c340ed9026334e5b2b8216cf553 100644 (file)
--- a/extensions/BMO/template/en/default/hook/flag/type_comment-form.html.tmpl
+++ b/extensions/BMO/template/en/default/hook/flag/type_comment-form.html.tmpl
@@ -8,7 +8,7 @@
 
 <meta name="extra-patch-types" content="text/x-phabricator-request">
 
-<template class="approval-request" data-flags="approval‑mozilla‑beta approval‑mozilla‑release">
+<template class="approval-request" data-flags="approval-mozilla-beta approval-mozilla-release">
   <section>
     <header>
       <h3>Beta/Release Uplift Approval Request</h3>
@@ -80,7 +80,7 @@
   </section>
 </template>
 
-<template class="approval-request" data-flags="approval‑mozilla‑esr*">
+<template class="approval-request" data-flags="approval-mozilla-esr*">
   <section>
     <header>
       <h3>ESR Uplift Approval Request</h3>
@@ -123,7 +123,7 @@
   </section>
 </template>
 
-<template class="approval-request" data-flags="approval‑mozilla‑geckoview*">
+<template class="approval-request" data-flags="approval-mozilla-geckoview*">
   <section>
     <header>
       <h3>GeckoView Uplift Approval Request</h3>
@@ -166,7 +166,7 @@
   </section>
 </template>
 
-<template class="approval-request" data-flags="sec‑approval">
+<template class="approval-request" data-flags="sec-approval">
   <section>
     <header>
       <h3>Security Approval Request</h3>

diff --git a/extensions/FlagTypeComment/web/js/ftc.js b/extensions/FlagTypeComment/web/js/ftc.js
index 855ca7748457b0ac0954413cfd3e7727f4829ae3..5756d06c1e5010a41b67a72fbd8ccf7b4039bf12 100644 (file)
--- a/extensions/FlagTypeComment/web/js/ftc.js
+++ b/extensions/FlagTypeComment/web/js/ftc.js
@@ -121,7 +121,7 @@ Bugzilla.FlagTypeComment = class FlagTypeComment {
   create_comment($fieldset) {
     return [
       `### ${$fieldset.querySelector('h3').innerText}`,
-      ...[...$fieldset.querySelectorAll('tr')].map($tr => {
+      ...[...$fieldset.querySelectorAll('tr:not(.other-patches)')].map($tr => {
         const checkboxes = [...$tr.querySelectorAll('input[type="checkbox"]:checked')];
         const $radio = $tr.querySelector('input[type="radio"]:checked');
         const $input = $tr.querySelector('textarea,select,input');

diff --git a/template/en/default/flag/list.html.tmpl b/template/en/default/flag/list.html.tmpl
index bb191e1dd68b4bda7506b75f46e781607799ce29..653c1aac61f3f5af4085fdaccaa3ca4d91e53668 100644 (file)
--- a/template/en/default/flag/list.html.tmpl
+++ b/template/en/default/flag/list.html.tmpl
@@ -131,7 +131,7 @@
                 title="[% type.description FILTER html %]"
                 onchange="toggleRequesteeField(this);"
                 class="flag_select flag_type-[% type.id %]"
-                data-id="[% type.id %]" data-name="[% type.name FILTER html FILTER no_break %]"
+                data-id="[% type.id %]" data-name="[% type.name FILTER html %]"
                 [% IF !can_edit_flag %] disabled="disabled"[% END %]>
         [% IF dontchange %]
           <option value="[% dontchange FILTER html %]" selected>[% dontchange FILTER html %]</option>