]> git.ipfire.org Git - thirdparty/systemd.git/commitdiff
efivars: use appropropriate uint8_t type when dealing with "raw" bytes
authorLennart Poettering <lennart@poettering.net>
Tue, 2 Jul 2024 15:50:47 +0000 (17:50 +0200)
committerLennart Poettering <lennart@poettering.net>
Tue, 2 Jul 2024 16:15:30 +0000 (18:15 +0200)
We don't actually want chars here, but rather raw bytes, in particular
to avoid signedness issues. Hence, let's use uint8_t here.

src/boot/efi/efivars.c

index 500cba36ba612435b6dc70778b07082cbe1961df..b69e1706781120862e32e40dfcff57882f9444f1 100644 (file)
@@ -133,7 +133,7 @@ EFI_STATUS efivar_get_uint_string(const EFI_GUID *vendor, const char16_t *name,
 }
 
 EFI_STATUS efivar_get_uint32_le(const EFI_GUID *vendor, const char16_t *name, uint32_t *ret) {
-        _cleanup_free_ char *buf = NULL;
+        _cleanup_free_ uint8_t *buf = NULL;
         size_t size;
         EFI_STATUS err;
 
@@ -155,7 +155,7 @@ EFI_STATUS efivar_get_uint32_le(const EFI_GUID *vendor, const char16_t *name, ui
 }
 
 EFI_STATUS efivar_get_uint64_le(const EFI_GUID *vendor, const char16_t *name, uint64_t *ret) {
-        _cleanup_free_ char *buf = NULL;
+        _cleanup_free_ uint8_t *buf = NULL;
         size_t size;
         EFI_STATUS err;
 
@@ -202,7 +202,7 @@ EFI_STATUS efivar_get_raw(const EFI_GUID *vendor, const char16_t *name, void **r
 }
 
 EFI_STATUS efivar_get_boolean_u8(const EFI_GUID *vendor, const char16_t *name, bool *ret) {
-        _cleanup_free_ char *b = NULL;
+        _cleanup_free_ uint8_t *b = NULL;
         size_t size;
         EFI_STATUS err;