]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
af_unix: Remove unix_unhash()
authorMichal Luczaj <mhal@rbox.co>
Wed, 9 Apr 2025 12:50:58 +0000 (14:50 +0200)
committerJakub Kicinski <kuba@kernel.org>
Fri, 11 Apr 2025 00:32:57 +0000 (17:32 -0700)
Dummy unix_unhash() was introduced for sockmap in commit 94531cfcbe79
("af_unix: Add unix_stream_proto for sockmap"), but there's no need to
implement it anymore.

->unhash() is only called conditionally: in unix_shutdown() since commit
d359902d5c35 ("af_unix: Fix NULL pointer bug in unix_shutdown"), and in BPF
proto's sock_map_unhash() since commit 5b4a79ba65a1 ("bpf, sockmap: Don't
let sock_map_{close,destroy,unhash} call itself").

Remove it.

Signed-off-by: Michal Luczaj <mhal@rbox.co>
Reviewed-by: Kuniyuki Iwashima <kuniyu@amazon.com>
Link: https://patch.msgid.link/20250409-cleanup-drop-unix-unhash-v1-1-1659e5b8ee84@rbox.co
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
net/unix/af_unix.c

index f78a2492826f9cc1e302ee6f8ca93c367656670a..2ab20821d6bb244a09e0364e1c649042360e23b1 100644 (file)
@@ -950,13 +950,6 @@ static void unix_close(struct sock *sk, long timeout)
         */
 }
 
-static void unix_unhash(struct sock *sk)
-{
-       /* Nothing to do here, unix socket does not need a ->unhash().
-        * This is merely for sockmap.
-        */
-}
-
 static bool unix_bpf_bypass_getsockopt(int level, int optname)
 {
        if (level == SOL_SOCKET) {
@@ -987,7 +980,6 @@ struct proto unix_stream_proto = {
        .owner                  = THIS_MODULE,
        .obj_size               = sizeof(struct unix_sock),
        .close                  = unix_close,
-       .unhash                 = unix_unhash,
        .bpf_bypass_getsockopt  = unix_bpf_bypass_getsockopt,
 #ifdef CONFIG_BPF_SYSCALL
        .psock_update_sk_prot   = unix_stream_bpf_update_proto,