]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
scsi: fusion: Remove unused variable 'rc'
authorZeng Heng <zengheng4@huawei.com>
Thu, 24 Oct 2024 08:44:17 +0000 (16:44 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 5 Dec 2024 09:59:34 +0000 (10:59 +0100)
[ Upstream commit bd65694223f7ad11c790ab63ad1af87a771192ee ]

The return value of scsi_device_reprobe() is currently ignored in
_scsih_reprobe_lun(). Fixing the calling code to deal with the potential
error is non-trivial, so for now just WARN_ON().

The handling of scsi_device_reprobe()'s return value refers to
_scsih_reprobe_lun() and the following link:

https://lore.kernel.org/all/094fdbf57487af4f395238c0525b2a560c8f68f0.1469766027.git.calvinowens@fb.com/

Fixes: f99be43b3024 ("[SCSI] fusion: power pc and miscellaneous bug fixs")
Signed-off-by: Zeng Heng <zengheng4@huawei.com>
Link: https://lore.kernel.org/r/20241024084417.154655-1-zengheng4@huawei.com
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/message/fusion/mptsas.c

index b8cf2658649ee1789edd9028f0b63dbd7020b560..7c8924dff17ff41e0a6681c362840a63c46803f4 100644 (file)
@@ -4206,10 +4206,8 @@ mptsas_find_phyinfo_by_phys_disk_num(MPT_ADAPTER *ioc, u8 phys_disk_num,
 static void
 mptsas_reprobe_lun(struct scsi_device *sdev, void *data)
 {
-       int rc;
-
        sdev->no_uld_attach = data ? 1 : 0;
-       rc = scsi_device_reprobe(sdev);
+       WARN_ON(scsi_device_reprobe(sdev));
 }
 
 static void