]> git.ipfire.org Git - thirdparty/gcc.git/commitdiff
gccrs: Resolve TypeParam with name resolution 2.0
authorPierre-Emmanuel Patry <pierre-emmanuel.patry@embecosm.com>
Thu, 26 Sep 2024 21:16:21 +0000 (23:16 +0200)
committerArthur Cohen <arthur.cohen@embecosm.com>
Wed, 19 Mar 2025 14:32:15 +0000 (15:32 +0100)
Resolve TypeParam unless it is Self.

gcc/rust/ChangeLog:

* resolve/rust-toplevel-name-resolver-2.0.cc (TopLevel::visit): Resolve
TypeParam.
* resolve/rust-toplevel-name-resolver-2.0.h: Add visit function
prototype.

Signed-off-by: Pierre-Emmanuel Patry <pierre-emmanuel.patry@embecosm.com>
gcc/rust/resolve/rust-toplevel-name-resolver-2.0.cc
gcc/rust/resolve/rust-toplevel-name-resolver-2.0.h

index 6a54978a67cb9d9bead5a0f82f33a00135aac235..35732e244b4ffc447b09a53a27b94c021220c74d 100644 (file)
@@ -253,6 +253,15 @@ TopLevel::visit (AST::StaticItem &static_item)
 void
 TopLevel::visit (AST::StructStruct &struct_item)
 {
+  auto generic_vis = [this, &struct_item] () {
+    for (auto &g : struct_item.get_generic_params ())
+      {
+       g->accept_vis (*this);
+      }
+  };
+
+  ctx.scoped (Rib::Kind::Item, struct_item.get_node_id (), generic_vis);
+
   insert_or_error_out (struct_item.get_struct_name (), struct_item,
                       Namespace::Types);
 
@@ -264,6 +273,16 @@ TopLevel::visit (AST::StructStruct &struct_item)
                         Namespace::Values);
 }
 
+void
+TopLevel::visit (AST::TypeParam &type_param)
+{
+  // Hacky and weird, find a better solution
+  // We should probably not even insert self in the first place ?
+  if (type_param.get_type_representation ().as_string () != "Self")
+    insert_or_error_out (type_param.get_type_representation (), type_param,
+                        Namespace::Types);
+}
+
 void
 TopLevel::visit (AST::TupleStruct &tuple_struct)
 {
index 99ed65398c6ae29e7fcddca6b89d4968791a765d..09b22612f78cf059c2589bed6f7d87d323455b21 100644 (file)
@@ -162,6 +162,7 @@ private:
   void visit (AST::Union &union_item) override;
   void visit (AST::ConstantItem &const_item) override;
   void visit (AST::ExternCrate &crate) override;
+  void visit (AST::TypeParam &type_param) override;
 
   void visit (AST::UseDeclaration &use) override;
 };