From 2.5: Properly quote wbinfo arguments, just in case.

2.5 commit log reads "Minor fix for Samba-3", but later changes made it
work anyway..

diff --git a/helpers/external_acl/wbinfo_group/wbinfo_group.pl b/helpers/external_acl/wbinfo_group/wbinfo_group.pl
index b8ebed826336d1dd19385a5f80d1954b244ff78e..d5fd00732b3857b00616d9bc09ac474d935bdf9b 100644 (file)
--- a/helpers/external_acl/wbinfo_group/wbinfo_group.pl
+++ b/helpers/external_acl/wbinfo_group/wbinfo_group.pl
@@ -47,7 +47,7 @@ sub check {
         local($user, $group) = @_;
         $groupSID = `wbinfo -n "$group" | cut -d" " -f1`;
         chop  $groupSID;
-        $groupGID = `wbinfo -Y $groupSID`;
+        $groupGID = `wbinfo -Y "$groupSID"`;
         chop $groupGID;
         &debug( "User:  -$user-\nGroup: -$group-\nSID:   -$groupSID-\nGID:   -$groupGID-");
         return 'OK' if(`wbinfo -r \Q$user\E` =~ /^$groupGID$/m);