]> git.ipfire.org Git - thirdparty/kernel/stable-queue.git/commitdiff
4.19-stable patches
authorGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sun, 14 Nov 2021 13:57:05 +0000 (14:57 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sun, 14 Nov 2021 13:57:05 +0000 (14:57 +0100)
added patches:
alsa-mixer-fix-deadlock-in-snd_mixer_oss_set_volume.patch
alsa-mixer-oss-fix-racy-access-to-slots.patch
pci-aardvark-do-not-clear-status-bits-of-masked-interrupts.patch
pci-aardvark-do-not-unmask-unused-interrupts.patch
pci-aardvark-fix-return-value-of-msi-domain-.alloc-method.patch
pci-aardvark-read-all-16-bits-from-pcie_msi_payload_reg.patch
quota-check-block-number-when-reading-the-block-in-quota-file.patch
quota-correct-error-number-in-free_dqentry.patch
xen-balloon-add-late_initcall_sync-for-initial-ballooning-done.patch

queue-4.19/alsa-mixer-fix-deadlock-in-snd_mixer_oss_set_volume.patch [new file with mode: 0644]
queue-4.19/alsa-mixer-oss-fix-racy-access-to-slots.patch [new file with mode: 0644]
queue-4.19/pci-aardvark-do-not-clear-status-bits-of-masked-interrupts.patch [new file with mode: 0644]
queue-4.19/pci-aardvark-do-not-unmask-unused-interrupts.patch [new file with mode: 0644]
queue-4.19/pci-aardvark-fix-return-value-of-msi-domain-.alloc-method.patch [new file with mode: 0644]
queue-4.19/pci-aardvark-read-all-16-bits-from-pcie_msi_payload_reg.patch [new file with mode: 0644]
queue-4.19/quota-check-block-number-when-reading-the-block-in-quota-file.patch [new file with mode: 0644]
queue-4.19/quota-correct-error-number-in-free_dqentry.patch [new file with mode: 0644]
queue-4.19/series
queue-4.19/xen-balloon-add-late_initcall_sync-for-initial-ballooning-done.patch [new file with mode: 0644]

diff --git a/queue-4.19/alsa-mixer-fix-deadlock-in-snd_mixer_oss_set_volume.patch b/queue-4.19/alsa-mixer-fix-deadlock-in-snd_mixer_oss_set_volume.patch
new file mode 100644 (file)
index 0000000..fd1a55a
--- /dev/null
@@ -0,0 +1,35 @@
+From 3ab7992018455ac63c33e9b3eaa7264e293e40f4 Mon Sep 17 00:00:00 2001
+From: Pavel Skripkin <paskripkin@gmail.com>
+Date: Sun, 24 Oct 2021 17:03:15 +0300
+Subject: ALSA: mixer: fix deadlock in snd_mixer_oss_set_volume
+
+From: Pavel Skripkin <paskripkin@gmail.com>
+
+commit 3ab7992018455ac63c33e9b3eaa7264e293e40f4 upstream.
+
+In commit 411cef6adfb3 ("ALSA: mixer: oss: Fix racy access to slots")
+added mutex protection in snd_mixer_oss_set_volume(). Second
+mutex_lock() in same function looks like typo, fix it.
+
+Reported-by: syzbot+ace149a75a9a0a399ac7@syzkaller.appspotmail.com
+Fixes: 411cef6adfb3 ("ALSA: mixer: oss: Fix racy access to slots")
+Cc: <stable@vger.kernel.org>
+Signed-off-by: Pavel Skripkin <paskripkin@gmail.com>
+Link: https://lore.kernel.org/r/20211024140315.16704-1-paskripkin@gmail.com
+Signed-off-by: Takashi Iwai <tiwai@suse.de>
+Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
+---
+ sound/core/oss/mixer_oss.c |    2 +-
+ 1 file changed, 1 insertion(+), 1 deletion(-)
+
+--- a/sound/core/oss/mixer_oss.c
++++ b/sound/core/oss/mixer_oss.c
+@@ -328,7 +328,7 @@ static int snd_mixer_oss_set_volume(stru
+       pslot->volume[1] = right;
+       result = (left & 0xff) | ((right & 0xff) << 8);
+  unlock:
+-      mutex_lock(&mixer->reg_mutex);
++      mutex_unlock(&mixer->reg_mutex);
+       return result;
+ }
diff --git a/queue-4.19/alsa-mixer-oss-fix-racy-access-to-slots.patch b/queue-4.19/alsa-mixer-oss-fix-racy-access-to-slots.patch
new file mode 100644 (file)
index 0000000..a7262bd
--- /dev/null
@@ -0,0 +1,176 @@
+From 411cef6adfb38a5bb6bd9af3941b28198e7fb680 Mon Sep 17 00:00:00 2001
+From: Takashi Iwai <tiwai@suse.de>
+Date: Wed, 20 Oct 2021 18:48:46 +0200
+Subject: ALSA: mixer: oss: Fix racy access to slots
+
+From: Takashi Iwai <tiwai@suse.de>
+
+commit 411cef6adfb38a5bb6bd9af3941b28198e7fb680 upstream.
+
+The OSS mixer can reassign the mapping slots dynamically via proc
+file.  Although the addition and deletion of those slots are protected
+by mixer->reg_mutex, the access to slots aren't, hence this may cause
+UAF when the slots in use are deleted concurrently.
+
+This patch applies the mixer->reg_mutex in all appropriate code paths
+(i.e. the ioctl functions) that may access slots.
+
+Reported-by: syzbot+9988f17cf72a1045a189@syzkaller.appspotmail.com
+Reviewed-by: Jaroslav Kysela <perex@perex.cz>
+Cc: <stable@vger.kernel.org>
+Link: https://lore.kernel.org/r/00000000000036adc005ceca9175@google.com
+Link: https://lore.kernel.org/r/20211020164846.922-1-tiwai@suse.de
+Signed-off-by: Takashi Iwai <tiwai@suse.de>
+Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
+---
+ sound/core/oss/mixer_oss.c |   43 +++++++++++++++++++++++++++++++++----------
+ 1 file changed, 33 insertions(+), 10 deletions(-)
+
+--- a/sound/core/oss/mixer_oss.c
++++ b/sound/core/oss/mixer_oss.c
+@@ -145,11 +145,13 @@ static int snd_mixer_oss_devmask(struct
+       if (mixer == NULL)
+               return -EIO;
++      mutex_lock(&mixer->reg_mutex);
+       for (chn = 0; chn < 31; chn++) {
+               pslot = &mixer->slots[chn];
+               if (pslot->put_volume || pslot->put_recsrc)
+                       result |= 1 << chn;
+       }
++      mutex_unlock(&mixer->reg_mutex);
+       return result;
+ }
+@@ -161,11 +163,13 @@ static int snd_mixer_oss_stereodevs(stru
+       if (mixer == NULL)
+               return -EIO;
++      mutex_lock(&mixer->reg_mutex);
+       for (chn = 0; chn < 31; chn++) {
+               pslot = &mixer->slots[chn];
+               if (pslot->put_volume && pslot->stereo)
+                       result |= 1 << chn;
+       }
++      mutex_unlock(&mixer->reg_mutex);
+       return result;
+ }
+@@ -176,6 +180,7 @@ static int snd_mixer_oss_recmask(struct
+       if (mixer == NULL)
+               return -EIO;
++      mutex_lock(&mixer->reg_mutex);
+       if (mixer->put_recsrc && mixer->get_recsrc) {   /* exclusive */
+               result = mixer->mask_recsrc;
+       } else {
+@@ -187,6 +192,7 @@ static int snd_mixer_oss_recmask(struct
+                               result |= 1 << chn;
+               }
+       }
++      mutex_unlock(&mixer->reg_mutex);
+       return result;
+ }
+@@ -197,11 +203,12 @@ static int snd_mixer_oss_get_recsrc(stru
+       if (mixer == NULL)
+               return -EIO;
++      mutex_lock(&mixer->reg_mutex);
+       if (mixer->put_recsrc && mixer->get_recsrc) {   /* exclusive */
+-              int err;
+               unsigned int index;
+-              if ((err = mixer->get_recsrc(fmixer, &index)) < 0)
+-                      return err;
++              result = mixer->get_recsrc(fmixer, &index);
++              if (result < 0)
++                      goto unlock;
+               result = 1 << index;
+       } else {
+               struct snd_mixer_oss_slot *pslot;
+@@ -216,7 +223,10 @@ static int snd_mixer_oss_get_recsrc(stru
+                       }
+               }
+       }
+-      return mixer->oss_recsrc = result;
++      mixer->oss_recsrc = result;
++ unlock:
++      mutex_unlock(&mixer->reg_mutex);
++      return result;
+ }
+ static int snd_mixer_oss_set_recsrc(struct snd_mixer_oss_file *fmixer, int recsrc)
+@@ -229,6 +239,7 @@ static int snd_mixer_oss_set_recsrc(stru
+       if (mixer == NULL)
+               return -EIO;
++      mutex_lock(&mixer->reg_mutex);
+       if (mixer->get_recsrc && mixer->put_recsrc) {   /* exclusive input */
+               if (recsrc & ~mixer->oss_recsrc)
+                       recsrc &= ~mixer->oss_recsrc;
+@@ -254,6 +265,7 @@ static int snd_mixer_oss_set_recsrc(stru
+                       }
+               }
+       }
++      mutex_unlock(&mixer->reg_mutex);
+       return result;
+ }
+@@ -265,6 +277,7 @@ static int snd_mixer_oss_get_volume(stru
+       if (mixer == NULL || slot > 30)
+               return -EIO;
++      mutex_lock(&mixer->reg_mutex);
+       pslot = &mixer->slots[slot];
+       left = pslot->volume[0];
+       right = pslot->volume[1];
+@@ -272,15 +285,21 @@ static int snd_mixer_oss_get_volume(stru
+               result = pslot->get_volume(fmixer, pslot, &left, &right);
+       if (!pslot->stereo)
+               right = left;
+-      if (snd_BUG_ON(left < 0 || left > 100))
+-              return -EIO;
+-      if (snd_BUG_ON(right < 0 || right > 100))
+-              return -EIO;
++      if (snd_BUG_ON(left < 0 || left > 100)) {
++              result = -EIO;
++              goto unlock;
++      }
++      if (snd_BUG_ON(right < 0 || right > 100)) {
++              result = -EIO;
++              goto unlock;
++      }
+       if (result >= 0) {
+               pslot->volume[0] = left;
+               pslot->volume[1] = right;
+               result = (left & 0xff) | ((right & 0xff) << 8);
+       }
++ unlock:
++      mutex_unlock(&mixer->reg_mutex);
+       return result;
+ }
+@@ -293,6 +312,7 @@ static int snd_mixer_oss_set_volume(stru
+       if (mixer == NULL || slot > 30)
+               return -EIO;
++      mutex_lock(&mixer->reg_mutex);
+       pslot = &mixer->slots[slot];
+       if (left > 100)
+               left = 100;
+@@ -303,10 +323,13 @@ static int snd_mixer_oss_set_volume(stru
+       if (pslot->put_volume)
+               result = pslot->put_volume(fmixer, pslot, left, right);
+       if (result < 0)
+-              return result;
++              goto unlock;
+       pslot->volume[0] = left;
+       pslot->volume[1] = right;
+-      return (left & 0xff) | ((right & 0xff) << 8);
++      result = (left & 0xff) | ((right & 0xff) << 8);
++ unlock:
++      mutex_lock(&mixer->reg_mutex);
++      return result;
+ }
+ static int snd_mixer_oss_ioctl1(struct snd_mixer_oss_file *fmixer, unsigned int cmd, unsigned long arg)
diff --git a/queue-4.19/pci-aardvark-do-not-clear-status-bits-of-masked-interrupts.patch b/queue-4.19/pci-aardvark-do-not-clear-status-bits-of-masked-interrupts.patch
new file mode 100644 (file)
index 0000000..949a602
--- /dev/null
@@ -0,0 +1,51 @@
+From a7ca6d7fa3c02c032db5440ff392d96c04684c21 Mon Sep 17 00:00:00 2001
+From: =?UTF-8?q?Pali=20Roh=C3=A1r?= <pali@kernel.org>
+Date: Tue, 5 Oct 2021 20:09:45 +0200
+Subject: PCI: aardvark: Do not clear status bits of masked interrupts
+MIME-Version: 1.0
+Content-Type: text/plain; charset=UTF-8
+Content-Transfer-Encoding: 8bit
+
+From: Pali Rohár <pali@kernel.org>
+
+commit a7ca6d7fa3c02c032db5440ff392d96c04684c21 upstream.
+
+The PCIE_ISR1_REG says which interrupts are currently set / active,
+including those which are masked.
+
+The driver currently reads this register and looks if some unmasked
+interrupts are active, and if not, it clears status bits of _all_
+interrupts, including the masked ones.
+
+This is incorrect, since, for example, some drivers may poll these bits.
+
+Remove this clearing, and also remove this early return statement
+completely, since it does not change functionality in any way.
+
+Link: https://lore.kernel.org/r/20211005180952.6812-7-kabel@kernel.org
+Fixes: 8c39d710363c ("PCI: aardvark: Add Aardvark PCI host controller driver")
+Signed-off-by: Pali Rohár <pali@kernel.org>
+Signed-off-by: Marek Behún <kabel@kernel.org>
+Signed-off-by: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
+Reviewed-by: Marek Behún <kabel@kernel.org>
+Cc: stable@vger.kernel.org
+Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
+---
+ drivers/pci/controller/pci-aardvark.c |    6 ------
+ 1 file changed, 6 deletions(-)
+
+--- a/drivers/pci/controller/pci-aardvark.c
++++ b/drivers/pci/controller/pci-aardvark.c
+@@ -828,12 +828,6 @@ static void advk_pcie_handle_int(struct
+       isr1_mask = advk_readl(pcie, PCIE_ISR1_MASK_REG);
+       isr1_status = isr1_val & ((~isr1_mask) & PCIE_ISR1_ALL_MASK);
+-      if (!isr0_status && !isr1_status) {
+-              advk_writel(pcie, isr0_val, PCIE_ISR0_REG);
+-              advk_writel(pcie, isr1_val, PCIE_ISR1_REG);
+-              return;
+-      }
+-
+       /* Process MSI interrupts */
+       if (isr0_status & PCIE_ISR0_MSI_INT_PENDING)
+               advk_pcie_handle_msi(pcie);
diff --git a/queue-4.19/pci-aardvark-do-not-unmask-unused-interrupts.patch b/queue-4.19/pci-aardvark-do-not-unmask-unused-interrupts.patch
new file mode 100644 (file)
index 0000000..5197e95
--- /dev/null
@@ -0,0 +1,56 @@
+From 1fb95d7d3c7a926b002fe8a6bd27a1cb428b46dc Mon Sep 17 00:00:00 2001
+From: =?UTF-8?q?Pali=20Roh=C3=A1r?= <pali@kernel.org>
+Date: Tue, 5 Oct 2021 20:09:46 +0200
+Subject: PCI: aardvark: Do not unmask unused interrupts
+MIME-Version: 1.0
+Content-Type: text/plain; charset=UTF-8
+Content-Transfer-Encoding: 8bit
+
+From: Pali Rohár <pali@kernel.org>
+
+commit 1fb95d7d3c7a926b002fe8a6bd27a1cb428b46dc upstream.
+
+There are lot of undocumented interrupt bits. To prevent unwanted
+spurious interrupts, fix all *_ALL_MASK macros to define all interrupt
+bits, so that driver can properly mask all interrupts, including those
+which are undocumented.
+
+Link: https://lore.kernel.org/r/20211005180952.6812-8-kabel@kernel.org
+Fixes: 8c39d710363c ("PCI: aardvark: Add Aardvark PCI host controller driver")
+Signed-off-by: Pali Rohár <pali@kernel.org>
+Signed-off-by: Marek Behún <kabel@kernel.org>
+Signed-off-by: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
+Reviewed-by: Marek Behún <kabel@kernel.org>
+Cc: stable@vger.kernel.org
+Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
+---
+ drivers/pci/controller/pci-aardvark.c |    6 +++---
+ 1 file changed, 3 insertions(+), 3 deletions(-)
+
+--- a/drivers/pci/controller/pci-aardvark.c
++++ b/drivers/pci/controller/pci-aardvark.c
+@@ -99,13 +99,13 @@
+ #define     PCIE_ISR0_MSI_INT_PENDING         BIT(24)
+ #define     PCIE_ISR0_INTX_ASSERT(val)                BIT(16 + (val))
+ #define     PCIE_ISR0_INTX_DEASSERT(val)      BIT(20 + (val))
+-#define           PCIE_ISR0_ALL_MASK                  GENMASK(26, 0)
++#define     PCIE_ISR0_ALL_MASK                        GENMASK(31, 0)
+ #define PCIE_ISR1_REG                         (CONTROL_BASE_ADDR + 0x48)
+ #define PCIE_ISR1_MASK_REG                    (CONTROL_BASE_ADDR + 0x4C)
+ #define     PCIE_ISR1_POWER_STATE_CHANGE      BIT(4)
+ #define     PCIE_ISR1_FLUSH                   BIT(5)
+ #define     PCIE_ISR1_INTX_ASSERT(val)                BIT(8 + (val))
+-#define     PCIE_ISR1_ALL_MASK                        GENMASK(11, 4)
++#define     PCIE_ISR1_ALL_MASK                        GENMASK(31, 0)
+ #define PCIE_MSI_ADDR_LOW_REG                 (CONTROL_BASE_ADDR + 0x50)
+ #define PCIE_MSI_ADDR_HIGH_REG                        (CONTROL_BASE_ADDR + 0x54)
+ #define PCIE_MSI_STATUS_REG                   (CONTROL_BASE_ADDR + 0x58)
+@@ -150,7 +150,7 @@
+ #define     PCIE_IRQ_MSI_INT2_DET             BIT(21)
+ #define     PCIE_IRQ_RC_DBELL_DET             BIT(22)
+ #define     PCIE_IRQ_EP_STATUS                        BIT(23)
+-#define     PCIE_IRQ_ALL_MASK                 0xfff0fb
++#define     PCIE_IRQ_ALL_MASK                 GENMASK(31, 0)
+ #define     PCIE_IRQ_ENABLE_INTS_MASK         PCIE_IRQ_CORE_INT
+ /* Transaction types */
diff --git a/queue-4.19/pci-aardvark-fix-return-value-of-msi-domain-.alloc-method.patch b/queue-4.19/pci-aardvark-fix-return-value-of-msi-domain-.alloc-method.patch
new file mode 100644 (file)
index 0000000..56bd3ef
--- /dev/null
@@ -0,0 +1,44 @@
+From e4313be1599d397625c14fb7826996813622decf Mon Sep 17 00:00:00 2001
+From: =?UTF-8?q?Marek=20Beh=C3=BAn?= <kabel@kernel.org>
+Date: Thu, 28 Oct 2021 20:56:54 +0200
+Subject: PCI: aardvark: Fix return value of MSI domain .alloc() method
+MIME-Version: 1.0
+Content-Type: text/plain; charset=UTF-8
+Content-Transfer-Encoding: 8bit
+
+From: Marek Behún <kabel@kernel.org>
+
+commit e4313be1599d397625c14fb7826996813622decf upstream.
+
+MSI domain callback .alloc() (implemented by advk_msi_irq_domain_alloc()
+function) should return zero on success, since non-zero value indicates
+failure.
+
+When the driver was converted to generic MSI API in commit f21a8b1b6837
+("PCI: aardvark: Move to MSI handling using generic MSI support"), it
+was converted so that it returns hwirq number.
+
+Fix this.
+
+Link: https://lore.kernel.org/r/20211028185659.20329-3-kabel@kernel.org
+Fixes: f21a8b1b6837 ("PCI: aardvark: Move to MSI handling using generic MSI support")
+Signed-off-by: Pali Rohár <pali@kernel.org>
+Signed-off-by: Marek Behún <kabel@kernel.org>
+Signed-off-by: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
+Cc: stable@vger.kernel.org
+Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
+---
+ drivers/pci/controller/pci-aardvark.c |    2 +-
+ 1 file changed, 1 insertion(+), 1 deletion(-)
+
+--- a/drivers/pci/controller/pci-aardvark.c
++++ b/drivers/pci/controller/pci-aardvark.c
+@@ -627,7 +627,7 @@ static int advk_msi_irq_domain_alloc(str
+                                   domain->host_data, handle_simple_irq,
+                                   NULL, NULL);
+-      return hwirq;
++      return 0;
+ }
+ static void advk_msi_irq_domain_free(struct irq_domain *domain,
diff --git a/queue-4.19/pci-aardvark-read-all-16-bits-from-pcie_msi_payload_reg.patch b/queue-4.19/pci-aardvark-read-all-16-bits-from-pcie_msi_payload_reg.patch
new file mode 100644 (file)
index 0000000..8148fd2
--- /dev/null
@@ -0,0 +1,51 @@
+From 95997723b6402cd6c53e0f9e7ac640ec64eaaff8 Mon Sep 17 00:00:00 2001
+From: =?UTF-8?q?Marek=20Beh=C3=BAn?= <kabel@kernel.org>
+Date: Thu, 28 Oct 2021 20:56:55 +0200
+Subject: PCI: aardvark: Read all 16-bits from PCIE_MSI_PAYLOAD_REG
+MIME-Version: 1.0
+Content-Type: text/plain; charset=UTF-8
+Content-Transfer-Encoding: 8bit
+
+From: Marek Behún <kabel@kernel.org>
+
+commit 95997723b6402cd6c53e0f9e7ac640ec64eaaff8 upstream.
+
+The PCIE_MSI_PAYLOAD_REG contains 16-bit MSI number, not only lower
+8 bits. Fix reading content of this register and add a comment
+describing the access to this register.
+
+Link: https://lore.kernel.org/r/20211028185659.20329-4-kabel@kernel.org
+Fixes: 8c39d710363c ("PCI: aardvark: Add Aardvark PCI host controller driver")
+Signed-off-by: Pali Rohár <pali@kernel.org>
+Signed-off-by: Marek Behún <kabel@kernel.org>
+Signed-off-by: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
+Cc: stable@vger.kernel.org
+Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
+---
+ drivers/pci/controller/pci-aardvark.c |    7 ++++++-
+ 1 file changed, 6 insertions(+), 1 deletion(-)
+
+--- a/drivers/pci/controller/pci-aardvark.c
++++ b/drivers/pci/controller/pci-aardvark.c
+@@ -111,6 +111,7 @@
+ #define PCIE_MSI_STATUS_REG                   (CONTROL_BASE_ADDR + 0x58)
+ #define PCIE_MSI_MASK_REG                     (CONTROL_BASE_ADDR + 0x5C)
+ #define PCIE_MSI_PAYLOAD_REG                  (CONTROL_BASE_ADDR + 0x9C)
++#define     PCIE_MSI_DATA_MASK                        GENMASK(15, 0)
+ /* LMI registers base address and register offsets */
+ #define LMI_BASE_ADDR                         0x6000
+@@ -805,8 +806,12 @@ static void advk_pcie_handle_msi(struct
+               if (!(BIT(msi_idx) & msi_status))
+                       continue;
++              /*
++               * msi_idx contains bits [4:0] of the msi_data and msi_data
++               * contains 16bit MSI interrupt number
++               */
+               advk_writel(pcie, BIT(msi_idx), PCIE_MSI_STATUS_REG);
+-              msi_data = advk_readl(pcie, PCIE_MSI_PAYLOAD_REG) & 0xFF;
++              msi_data = advk_readl(pcie, PCIE_MSI_PAYLOAD_REG) & PCIE_MSI_DATA_MASK;
+               generic_handle_irq(msi_data);
+       }
diff --git a/queue-4.19/quota-check-block-number-when-reading-the-block-in-quota-file.patch b/queue-4.19/quota-check-block-number-when-reading-the-block-in-quota-file.patch
new file mode 100644 (file)
index 0000000..ac813a1
--- /dev/null
@@ -0,0 +1,54 @@
+From 9bf3d20331295b1ecb81f4ed9ef358c51699a050 Mon Sep 17 00:00:00 2001
+From: Zhang Yi <yi.zhang@huawei.com>
+Date: Fri, 8 Oct 2021 17:38:20 +0800
+Subject: quota: check block number when reading the block in quota file
+
+From: Zhang Yi <yi.zhang@huawei.com>
+
+commit 9bf3d20331295b1ecb81f4ed9ef358c51699a050 upstream.
+
+The block number in the quota tree on disk should be smaller than the
+v2_disk_dqinfo.dqi_blocks. If the quota file was corrupted, we may be
+allocating an 'allocated' block and that would lead to a loop in a tree,
+which will probably trigger oops later. This patch adds a check for the
+block number in the quota tree to prevent such potential issue.
+
+Link: https://lore.kernel.org/r/20211008093821.1001186-2-yi.zhang@huawei.com
+Signed-off-by: Zhang Yi <yi.zhang@huawei.com>
+Cc: stable@kernel.org
+Signed-off-by: Jan Kara <jack@suse.cz>
+Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
+---
+ fs/quota/quota_tree.c |   14 ++++++++++++++
+ 1 file changed, 14 insertions(+)
+
+--- a/fs/quota/quota_tree.c
++++ b/fs/quota/quota_tree.c
+@@ -487,6 +487,13 @@ static int remove_tree(struct qtree_mem_
+               goto out_buf;
+       }
+       newblk = le32_to_cpu(ref[get_index(info, dquot->dq_id, depth)]);
++      if (newblk < QT_TREEOFF || newblk >= info->dqi_blocks) {
++              quota_error(dquot->dq_sb, "Getting block too big (%u >= %u)",
++                          newblk, info->dqi_blocks);
++              ret = -EUCLEAN;
++              goto out_buf;
++      }
++
+       if (depth == info->dqi_qtree_depth - 1) {
+               ret = free_dqentry(info, dquot, newblk);
+               newblk = 0;
+@@ -586,6 +593,13 @@ static loff_t find_tree_dqentry(struct q
+       blk = le32_to_cpu(ref[get_index(info, dquot->dq_id, depth)]);
+       if (!blk)       /* No reference? */
+               goto out_buf;
++      if (blk < QT_TREEOFF || blk >= info->dqi_blocks) {
++              quota_error(dquot->dq_sb, "Getting block too big (%u >= %u)",
++                          blk, info->dqi_blocks);
++              ret = -EUCLEAN;
++              goto out_buf;
++      }
++
+       if (depth < info->dqi_qtree_depth - 1)
+               ret = find_tree_dqentry(info, dquot, blk, depth+1);
+       else
diff --git a/queue-4.19/quota-correct-error-number-in-free_dqentry.patch b/queue-4.19/quota-correct-error-number-in-free_dqentry.patch
new file mode 100644 (file)
index 0000000..c307f39
--- /dev/null
@@ -0,0 +1,32 @@
+From d0e36a62bd4c60c09acc40e06ba4831a4d0bc75b Mon Sep 17 00:00:00 2001
+From: Zhang Yi <yi.zhang@huawei.com>
+Date: Fri, 8 Oct 2021 17:38:21 +0800
+Subject: quota: correct error number in free_dqentry()
+
+From: Zhang Yi <yi.zhang@huawei.com>
+
+commit d0e36a62bd4c60c09acc40e06ba4831a4d0bc75b upstream.
+
+Fix the error path in free_dqentry(), pass out the error number if the
+block to free is not correct.
+
+Fixes: 1ccd14b9c271 ("quota: Split off quota tree handling into a separate file")
+Link: https://lore.kernel.org/r/20211008093821.1001186-3-yi.zhang@huawei.com
+Signed-off-by: Zhang Yi <yi.zhang@huawei.com>
+Cc: stable@kernel.org
+Signed-off-by: Jan Kara <jack@suse.cz>
+Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
+---
+ fs/quota/quota_tree.c |    1 +
+ 1 file changed, 1 insertion(+)
+
+--- a/fs/quota/quota_tree.c
++++ b/fs/quota/quota_tree.c
+@@ -422,6 +422,7 @@ static int free_dqentry(struct qtree_mem
+               quota_error(dquot->dq_sb, "Quota structure has offset to "
+                       "other block (%u) than it should (%u)", blk,
+                       (uint)(dquot->dq_off >> info->dqi_blocksize_bits));
++              ret = -EIO;
+               goto out_buf;
+       }
+       ret = read_blk(info, blk, buf);
index 7861cff202461b3b9cd0ea60205e8b99c4136e3a..71336002288fb890bf20db9d35f047e5f870e4e0 100644 (file)
@@ -70,3 +70,12 @@ power-supply-max17042_battery-use-vfsoc-for-capacity-when-no-rsns.patch
 powerpc-85xx-fix-oops-when-mpc85xx_smp_guts_ids-node-cannot-be-found.patch
 serial-core-fix-initializing-and-restoring-termios-speed.patch
 ifb-fix-building-without-config_net_cls_act.patch
+alsa-mixer-oss-fix-racy-access-to-slots.patch
+alsa-mixer-fix-deadlock-in-snd_mixer_oss_set_volume.patch
+xen-balloon-add-late_initcall_sync-for-initial-ballooning-done.patch
+pci-aardvark-do-not-clear-status-bits-of-masked-interrupts.patch
+pci-aardvark-do-not-unmask-unused-interrupts.patch
+pci-aardvark-fix-return-value-of-msi-domain-.alloc-method.patch
+pci-aardvark-read-all-16-bits-from-pcie_msi_payload_reg.patch
+quota-check-block-number-when-reading-the-block-in-quota-file.patch
+quota-correct-error-number-in-free_dqentry.patch
diff --git a/queue-4.19/xen-balloon-add-late_initcall_sync-for-initial-ballooning-done.patch b/queue-4.19/xen-balloon-add-late_initcall_sync-for-initial-ballooning-done.patch
new file mode 100644 (file)
index 0000000..30d9d62
--- /dev/null
@@ -0,0 +1,245 @@
+From 40fdea0284bb20814399da0484a658a96c735d90 Mon Sep 17 00:00:00 2001
+From: Juergen Gross <jgross@suse.com>
+Date: Tue, 2 Nov 2021 10:19:44 +0100
+Subject: xen/balloon: add late_initcall_sync() for initial ballooning done
+MIME-Version: 1.0
+Content-Type: text/plain; charset=UTF-8
+Content-Transfer-Encoding: 8bit
+
+From: Juergen Gross <jgross@suse.com>
+
+commit 40fdea0284bb20814399da0484a658a96c735d90 upstream.
+
+When running as PVH or HVM guest with actual memory < max memory the
+hypervisor is using "populate on demand" in order to allow the guest
+to balloon down from its maximum memory size. For this to work
+correctly the guest must not touch more memory pages than its target
+memory size as otherwise the PoD cache will be exhausted and the guest
+is crashed as a result of that.
+
+In extreme cases ballooning down might not be finished today before
+the init process is started, which can consume lots of memory.
+
+In order to avoid random boot crashes in such cases, add a late init
+call to wait for ballooning down having finished for PVH/HVM guests.
+
+Warn on console if initial ballooning fails, panic() after stalling
+for more than 3 minutes per default. Add a module parameter for
+changing this timeout.
+
+[boris: replaced pr_info() with pr_notice()]
+
+Cc: <stable@vger.kernel.org>
+Reported-by: Marek Marczykowski-Górecki <marmarek@invisiblethingslab.com>
+Signed-off-by: Juergen Gross <jgross@suse.com>
+Link: https://lore.kernel.org/r/20211102091944.17487-1-jgross@suse.com
+Reviewed-by: Boris Ostrovsky <boris.ostrovsky@oracle.com>
+Signed-off-by: Boris Ostrovsky <boris.ostrovsky@oracle.com>
+Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
+---
+ Documentation/admin-guide/kernel-parameters.txt |    7 +
+ drivers/xen/balloon.c                           |   86 +++++++++++++++++-------
+ 2 files changed, 70 insertions(+), 23 deletions(-)
+
+--- a/Documentation/admin-guide/kernel-parameters.txt
++++ b/Documentation/admin-guide/kernel-parameters.txt
+@@ -5284,6 +5284,13 @@
+                       with /sys/devices/system/xen_memory/xen_memory0/scrub_pages.
+                       Default value controlled with CONFIG_XEN_SCRUB_PAGES_DEFAULT.
++      xen.balloon_boot_timeout= [XEN]
++                      The time (in seconds) to wait before giving up to boot
++                      in case initial ballooning fails to free enough memory.
++                      Applies only when running as HVM or PVH guest and
++                      started with less memory configured than allowed at
++                      max. Default is 180.
++
+       xen.event_eoi_delay=    [XEN]
+                       How long to delay EOI handling in case of event
+                       storms (jiffies). Default is 10.
+--- a/drivers/xen/balloon.c
++++ b/drivers/xen/balloon.c
+@@ -58,6 +58,7 @@
+ #include <linux/percpu-defs.h>
+ #include <linux/slab.h>
+ #include <linux/sysctl.h>
++#include <linux/moduleparam.h>
+ #include <asm/page.h>
+ #include <asm/pgalloc.h>
+@@ -75,6 +76,12 @@
+ #include <xen/page.h>
+ #include <xen/mem-reservation.h>
++#undef MODULE_PARAM_PREFIX
++#define MODULE_PARAM_PREFIX "xen."
++
++static uint __read_mostly balloon_boot_timeout = 180;
++module_param(balloon_boot_timeout, uint, 0444);
++
+ static int xen_hotplug_unpopulated;
+ #ifdef CONFIG_XEN_BALLOON_MEMORY_HOTPLUG
+@@ -130,12 +137,12 @@ static struct ctl_table xen_root[] = {
+  * BP_ECANCELED: error, balloon operation canceled.
+  */
+-enum bp_state {
++static enum bp_state {
+       BP_DONE,
+       BP_WAIT,
+       BP_EAGAIN,
+       BP_ECANCELED
+-};
++} balloon_state = BP_DONE;
+ /* Main waiting point for xen-balloon thread. */
+ static DECLARE_WAIT_QUEUE_HEAD(balloon_thread_wq);
+@@ -206,18 +213,15 @@ static struct page *balloon_next_page(st
+       return list_entry(next, struct page, lru);
+ }
+-static enum bp_state update_schedule(enum bp_state state)
++static void update_schedule(void)
+ {
+-      if (state == BP_WAIT)
+-              return BP_WAIT;
+-
+-      if (state == BP_ECANCELED)
+-              return BP_ECANCELED;
++      if (balloon_state == BP_WAIT || balloon_state == BP_ECANCELED)
++              return;
+-      if (state == BP_DONE) {
++      if (balloon_state == BP_DONE) {
+               balloon_stats.schedule_delay = 1;
+               balloon_stats.retry_count = 1;
+-              return BP_DONE;
++              return;
+       }
+       ++balloon_stats.retry_count;
+@@ -226,7 +230,8 @@ static enum bp_state update_schedule(enu
+                       balloon_stats.retry_count > balloon_stats.max_retry_count) {
+               balloon_stats.schedule_delay = 1;
+               balloon_stats.retry_count = 1;
+-              return BP_ECANCELED;
++              balloon_state = BP_ECANCELED;
++              return;
+       }
+       balloon_stats.schedule_delay <<= 1;
+@@ -234,7 +239,7 @@ static enum bp_state update_schedule(enu
+       if (balloon_stats.schedule_delay > balloon_stats.max_schedule_delay)
+               balloon_stats.schedule_delay = balloon_stats.max_schedule_delay;
+-      return BP_EAGAIN;
++      balloon_state = BP_EAGAIN;
+ }
+ #ifdef CONFIG_XEN_BALLOON_MEMORY_HOTPLUG
+@@ -511,9 +516,9 @@ static enum bp_state decrease_reservatio
+  * Stop waiting if either state is BP_DONE and ballooning action is
+  * needed, or if the credit has changed while state is not BP_DONE.
+  */
+-static bool balloon_thread_cond(enum bp_state state, long credit)
++static bool balloon_thread_cond(long credit)
+ {
+-      if (state == BP_DONE)
++      if (balloon_state == BP_DONE)
+               credit = 0;
+       return current_credit() != credit || kthread_should_stop();
+@@ -527,13 +532,12 @@ static bool balloon_thread_cond(enum bp_
+  */
+ static int balloon_thread(void *unused)
+ {
+-      enum bp_state state = BP_DONE;
+       long credit;
+       unsigned long timeout;
+       set_freezable();
+       for (;;) {
+-              switch (state) {
++              switch (balloon_state) {
+               case BP_DONE:
+               case BP_ECANCELED:
+                       timeout = 3600 * HZ;
+@@ -549,7 +553,7 @@ static int balloon_thread(void *unused)
+               credit = current_credit();
+               wait_event_freezable_timeout(balloon_thread_wq,
+-                      balloon_thread_cond(state, credit), timeout);
++                      balloon_thread_cond(credit), timeout);
+               if (kthread_should_stop())
+                       return 0;
+@@ -560,22 +564,23 @@ static int balloon_thread(void *unused)
+               if (credit > 0) {
+                       if (balloon_is_inflated())
+-                              state = increase_reservation(credit);
++                              balloon_state = increase_reservation(credit);
+                       else
+-                              state = reserve_additional_memory();
++                              balloon_state = reserve_additional_memory();
+               }
+               if (credit < 0) {
+                       long n_pages;
+                       n_pages = min(-credit, si_mem_available());
+-                      state = decrease_reservation(n_pages, GFP_BALLOON);
+-                      if (state == BP_DONE && n_pages != -credit &&
++                      balloon_state = decrease_reservation(n_pages,
++                                                           GFP_BALLOON);
++                      if (balloon_state == BP_DONE && n_pages != -credit &&
+                           n_pages < totalreserve_pages)
+-                              state = BP_EAGAIN;
++                              balloon_state = BP_EAGAIN;
+               }
+-              state = update_schedule(state);
++              update_schedule();
+               mutex_unlock(&balloon_mutex);
+@@ -784,3 +789,38 @@ static int __init balloon_init(void)
+       return 0;
+ }
+ subsys_initcall(balloon_init);
++
++static int __init balloon_wait_finish(void)
++{
++      long credit, last_credit = 0;
++      unsigned long last_changed = 0;
++
++      if (!xen_domain())
++              return -ENODEV;
++
++      /* PV guests don't need to wait. */
++      if (xen_pv_domain() || !current_credit())
++              return 0;
++
++      pr_notice("Waiting for initial ballooning down having finished.\n");
++
++      while ((credit = current_credit()) < 0) {
++              if (credit != last_credit) {
++                      last_changed = jiffies;
++                      last_credit = credit;
++              }
++              if (balloon_state == BP_ECANCELED) {
++                      pr_warn_once("Initial ballooning failed, %ld pages need to be freed.\n",
++                                   -credit);
++                      if (jiffies - last_changed >= HZ * balloon_boot_timeout)
++                              panic("Initial ballooning failed!\n");
++              }
++
++              schedule_timeout_interruptible(HZ / 10);
++      }
++
++      pr_notice("Initial ballooning down finished.\n");
++
++      return 0;
++}
++late_initcall_sync(balloon_wait_finish);