]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
drm/bridge: anx7625: fix drm_bridge ops flags to support hot-plugging
authorAyushi Makhija <quic_amakhija@quicinc.com>
Mon, 5 May 2025 09:42:43 +0000 (15:12 +0530)
committerDmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
Mon, 5 May 2025 14:23:34 +0000 (17:23 +0300)
The anx7625_link_bridge() checks if a device is not a panel
bridge and add DRM_BRIDGE_OP_HPD and DRM_BRIDGE_OP_DETECT
flags to the drm_bridge->ops. However, on port 1 of the anx7625
bridge, any device added is always treated as a panel bridge,
preventing connector_detect() from being called. To resolve
this, instead of just checking if it is a panel bridge, verify
the type of device based on aux whether it is a DisplayPort or
eDP panel. If the device is not of the eDP type, add
DRM_BRIDGE_OP_HPD and DRM_BRIDGE_OP_DETECT flags to the to
the drm_bridge->ops.

Signed-off-by: Ayushi Makhija <quic_amakhija@quicinc.com>
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
Link: https://lore.kernel.org/r/20250505094245.2660750-5-quic_amakhija@quicinc.com
Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
drivers/gpu/drm/bridge/analogix/anx7625.c

index 8cfae7f3c9eec16a37fdc86b427340edc929b6f8..a791a2df951a13fe21615fb365b11b5fc5df123e 100644 (file)
@@ -2603,9 +2603,8 @@ static int anx7625_link_bridge(struct drm_dp_aux *aux)
        platform->bridge.of_node = dev->of_node;
        if (!anx7625_of_panel_on_aux_bus(dev))
                platform->bridge.ops |= DRM_BRIDGE_OP_EDID;
-       if (!platform->pdata.panel_bridge)
-               platform->bridge.ops |= DRM_BRIDGE_OP_HPD |
-                                       DRM_BRIDGE_OP_DETECT;
+       if (!platform->pdata.panel_bridge || !anx7625_of_panel_on_aux_bus(dev))
+               platform->bridge.ops |= DRM_BRIDGE_OP_HPD | DRM_BRIDGE_OP_DETECT;
        platform->bridge.type = platform->pdata.panel_bridge ?
                                    DRM_MODE_CONNECTOR_eDP :
                                    DRM_MODE_CONNECTOR_DisplayPort;