]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
net: usb: smsc95xx: Fix an error code in smsc95xx_reset()
authorDan Carpenter <dan.carpenter@linaro.org>
Mon, 16 Oct 2023 17:28:10 +0000 (20:28 +0300)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 25 Oct 2023 09:13:32 +0000 (11:13 +0200)
commit c53647a5df9e66dd9fedf240198e1fe50d88c286 upstream.

Return a negative error code instead of success.

Fixes: 2f7ca802bdae ("net: Add SMSC LAN9500 USB2.0 10/100 ethernet adapter driver")
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Link: https://lore.kernel.org/r/147927f0-9ada-45cc-81ff-75a19dd30b76@moroto.mountain
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/net/usb/smsc95xx.c

index b1e3ec3dcac3bb86014d4f0d81ce1470ca5ea802..e70eac578f5e0bde1e194f469166b423c4167844 100644 (file)
@@ -1054,7 +1054,7 @@ static int smsc95xx_reset(struct usbnet *dev)
 
        if (timeout >= 100) {
                netdev_warn(dev->net, "timeout waiting for completion of Lite Reset\n");
-               return ret;
+               return -ETIMEDOUT;
        }
 
        ret = smsc95xx_write_reg(dev, PM_CTRL, PM_CTL_PHY_RST_);