]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
drm/msm/dpu: check ubwc support before adding compressed formats
authorAbhinav Kumar <quic_abhinavk@quicinc.com>
Fri, 28 Jun 2024 23:39:27 +0000 (16:39 -0700)
committerRob Clark <robdclark@chromium.org>
Mon, 1 Jul 2024 20:54:40 +0000 (13:54 -0700)
On QCM2290 chipset DPU does not support UBWC.

Add a dpu cap to indicate this and do not expose compressed formats
in this case.

changes since RFC:
- use ubwc enc and dec version of mdss_data instead of catalog
  to decide if ubwc is supported

Signed-off-by: Abhinav Kumar <quic_abhinavk@quicinc.com>
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Patchwork: https://patchwork.freedesktop.org/patch/601392/
Signed-off-by: Rob Clark <robdclark@chromium.org>
drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c

index 1c3a2657450c6d6f090eddf6e7d621bb1f71278e..40c4dd2c3139fe7e56361e12135ae299128d139e 100644 (file)
@@ -18,6 +18,7 @@
 #include <drm/drm_gem_atomic_helper.h>
 
 #include "msm_drv.h"
+#include "msm_mdss.h"
 #include "dpu_kms.h"
 #include "dpu_formats.h"
 #include "dpu_hw_sspp.h"
@@ -1342,10 +1343,14 @@ void dpu_plane_danger_signal_ctrl(struct drm_plane *plane, bool enable)
 static bool dpu_plane_format_mod_supported(struct drm_plane *plane,
                uint32_t format, uint64_t modifier)
 {
+       struct dpu_kms *dpu_kms = _dpu_plane_get_kms(plane);
+       bool has_no_ubwc = (dpu_kms->mdss->ubwc_enc_version == 0) &&
+                          (dpu_kms->mdss->ubwc_dec_version == 0);
+
        if (modifier == DRM_FORMAT_MOD_LINEAR)
                return true;
 
-       if (modifier == DRM_FORMAT_MOD_QCOM_COMPRESSED)
+       if (modifier == DRM_FORMAT_MOD_QCOM_COMPRESSED && !has_no_ubwc)
                return dpu_find_format(format, qcom_compressed_supported_formats,
                                ARRAY_SIZE(qcom_compressed_supported_formats));