]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
minmax.h: add whitespace around operators and after commas
authorDavid Laight <David.Laight@ACULAB.COM>
Mon, 18 Nov 2024 19:11:24 +0000 (19:11 +0000)
committerAndrew Morton <akpm@linux-foundation.org>
Sat, 25 Jan 2025 06:47:26 +0000 (22:47 -0800)
Patch series "minmax.h: Cleanups and minor optimisations".

Some tidyups and minor changes to minmax.h.

This patch (of 7):

Link: https://lkml.kernel.org/r/c50365d214e04f9ba256d417c8bebbc0@AcuMS.aculab.com
Link: https://lkml.kernel.org/r/f04b2e1310244f62826267346fde0553@AcuMS.aculab.com
Signed-off-by: David Laight <david.laight@aculab.com>
Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: Arnd Bergmann <arnd@kernel.org>
Cc: Christoph Hellwig <hch@infradead.org>
Cc: Dan Carpenter <dan.carpenter@linaro.org>
Cc: Jason A. Donenfeld <Jason@zx2c4.com>
Cc: Jens Axboe <axboe@kernel.dk>
Cc: Lorenzo Stoakes <lorenzo.stoakes@oracle.com>
Cc: Mateusz Guzik <mjguzik@gmail.com>
Cc: Matthew Wilcox <willy@infradead.org>
Cc: Pedro Falcato <pedro.falcato@gmail.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
include/linux/minmax.h

index 98008dd92153db10c672155bca93201ffabee994..51b0d988e3222fd02af25334fc7d0a24f6e52161 100644 (file)
  * only need to be careful to not cause warnings for
  * pointer use.
  */
-#define __signed_type_use(x,ux) (2+__is_nonneg(x,ux))
-#define __unsigned_type_use(x,ux) (1+2*(sizeof(ux)<4))
-#define __sign_use(x,ux) (is_signed_type(typeof(ux))? \
-       __signed_type_use(x,ux):__unsigned_type_use(x,ux))
+#define __signed_type_use(x, ux) (2 + __is_nonneg(x, ux))
+#define __unsigned_type_use(x, ux) (1 + 2 * (sizeof(ux) < 4))
+#define __sign_use(x, ux) (is_signed_type(typeof(ux)) ? \
+       __signed_type_use(x, ux) : __unsigned_type_use(x, ux))
 
 /*
  * To avoid warnings about casting pointers to integers
 #ifdef CONFIG_64BIT
   #define __signed_type(ux) long
 #else
-  #define __signed_type(ux) typeof(__builtin_choose_expr(sizeof(ux)>4,1LL,1L))
+  #define __signed_type(ux) typeof(__builtin_choose_expr(sizeof(ux) > 4, 1LL, 1L))
 #endif
-#define __is_nonneg(x,ux) statically_true((__signed_type(ux))(x)>=0)
+#define __is_nonneg(x, ux) statically_true((__signed_type(ux))(x) >= 0)
 
-#define __types_ok(x,y,ux,uy) \
-       (__sign_use(x,ux) & __sign_use(y,uy))
+#define __types_ok(x, y, ux, uy) \
+       (__sign_use(x, ux) & __sign_use(y, uy))
 
-#define __types_ok3(x,y,z,ux,uy,uz) \
-       (__sign_use(x,ux) & __sign_use(y,uy) & __sign_use(z,uz))
+#define __types_ok3(x, y, z, ux, uy, uz) \
+       (__sign_use(x, ux) & __sign_use(y, uy) & __sign_use(z, uz))
 
 #define __cmp_op_min <
 #define __cmp_op_max >
@@ -97,7 +97,7 @@
 
 #define __careful_cmp_once(op, x, y, ux, uy) ({                \
        __auto_type ux = (x); __auto_type uy = (y);     \
-       BUILD_BUG_ON_MSG(!__types_ok(x,y,ux,uy),        \
+       BUILD_BUG_ON_MSG(!__types_ok(x, y, ux, uy),     \
                #op"("#x", "#y") signedness error");    \
        __cmp(op, ux, uy); })
 
        static_assert(__builtin_choose_expr(__is_constexpr((lo) > (hi)),        \
                        (lo) <= (hi), true),                                    \
                "clamp() low limit " #lo " greater than high limit " #hi);      \
-       BUILD_BUG_ON_MSG(!__types_ok3(val,lo,hi,uval,ulo,uhi),                  \
+       BUILD_BUG_ON_MSG(!__types_ok3(val, lo, hi, uval, ulo, uhi),             \
                "clamp("#val", "#lo", "#hi") signedness error");                \
        __clamp(uval, ulo, uhi); })
 
 
 #define __careful_op3(op, x, y, z, ux, uy, uz) ({                      \
        __auto_type ux = (x); __auto_type uy = (y);__auto_type uz = (z);\
-       BUILD_BUG_ON_MSG(!__types_ok3(x,y,z,ux,uy,uz),                  \
+       BUILD_BUG_ON_MSG(!__types_ok3(x, y, z, ux, uy, uz),             \
                #op"3("#x", "#y", "#z") signedness error");             \
        __cmp(op, ux, __cmp(op, uy, uz)); })
 
@@ -326,9 +326,9 @@ static inline bool in_range32(u32 val, u32 start, u32 len)
  * Use these carefully: no type checking, and uses the arguments
  * multiple times. Use for obvious constants only.
  */
-#define MIN(a,b) __cmp(min,a,b)
-#define MAX(a,b) __cmp(max,a,b)
-#define MIN_T(type,a,b) __cmp(min,(type)(a),(type)(b))
-#define MAX_T(type,a,b) __cmp(max,(type)(a),(type)(b))
+#define MIN(a, b) __cmp(min, a, b)
+#define MAX(a, b) __cmp(max, a, b)
+#define MIN_T(type, a, b) __cmp(min, (type)(a), (type)(b))
+#define MAX_T(type, a, b) __cmp(max, (type)(a), (type)(b))
 
 #endif /* _LINUX_MINMAX_H */