]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
drm/amdgpu: refine isp firmware loading
authorYang Wang <kevinyang.wang@amd.com>
Thu, 30 May 2024 14:48:34 +0000 (22:48 +0800)
committerAlex Deucher <alexander.deucher@amd.com>
Thu, 27 Jun 2024 21:34:40 +0000 (17:34 -0400)
refine isp firmware loading

Signed-off-by: Yang Wang <kevinyang.wang@amd.com>
Reviewed-by: Christian König <christian.koenig@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
drivers/gpu/drm/amd/amdgpu/amdgpu_isp.c

index 2a3f4668cb9b5d5f60e71a1de164bf1d8f9a551e..215bae80915350cdcb0777440a6bff834412c5a2 100644 (file)
@@ -97,16 +97,14 @@ static int isp_load_fw_by_psp(struct amdgpu_device *adev)
 {
        const struct common_firmware_header *hdr;
        char ucode_prefix[10];
-       char fw_name[40];
        int r = 0;
 
        /* get isp fw binary name and path */
        amdgpu_ucode_ip_version_decode(adev, ISP_HWIP, ucode_prefix,
                                       sizeof(ucode_prefix));
-       snprintf(fw_name, sizeof(fw_name), "amdgpu/%s.bin", ucode_prefix);
 
        /* read isp fw */
-       r = amdgpu_ucode_request(adev, &adev->isp.fw, fw_name);
+       r = amdgpu_ucode_request(adev, &adev->isp.fw, "amdgpu/%s.bin", ucode_prefix);
        if (r) {
                amdgpu_ucode_release(&adev->isp.fw);
                return r;