]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
media: sun6i-isp: capture: Fix uninitialized variable use
authorPaul Kocialkowski <paul.kocialkowski@bootlin.com>
Thu, 8 Dec 2022 14:20:04 +0000 (15:20 +0100)
committerMauro Carvalho Chehab <mchehab@kernel.org>
Wed, 14 Dec 2022 18:12:31 +0000 (18:12 +0000)
While the stride_chroma variable was previously initialized to zero,
it's actually stride_chroma_div4 that is set to hardware registers.

Initialize it to zero instead to avoid an uninitialized variable use
and get rid of the associated smatch warning.

Signed-off-by: Paul Kocialkowski <paul.kocialkowski@bootlin.com>
Fixes: e3185e1d7c14 ("media: staging: media: Add support for the Allwinner A31 ISP")
Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
drivers/staging/media/sunxi/sun6i-isp/sun6i_isp_capture.c

index 4b592820845a9ef66a738536d554060872953392..1595a9607775b51f5a11607dca0075c9b076a674 100644 (file)
@@ -108,8 +108,8 @@ sun6i_isp_capture_buffer_configure(struct sun6i_isp_device *isp_dev,
 void sun6i_isp_capture_configure(struct sun6i_isp_device *isp_dev)
 {
        unsigned int width, height;
-       unsigned int stride_luma, stride_chroma = 0;
-       unsigned int stride_luma_div4, stride_chroma_div4;
+       unsigned int stride_luma, stride_chroma;
+       unsigned int stride_luma_div4, stride_chroma_div4 = 0;
        const struct sun6i_isp_capture_format *format;
        const struct v4l2_format_info *info;
        u32 pixelformat;