]> git.ipfire.org Git - thirdparty/qemu.git/commitdiff
block/qapi: Plug memory leak in dump_qobject() case QTYPE_QERROR
authorMarkus Armbruster <armbru@redhat.com>
Wed, 28 May 2014 09:17:03 +0000 (11:17 +0200)
committerMichael Roth <mdroth@linux.vnet.ibm.com>
Thu, 3 Jul 2014 21:31:29 +0000 (16:31 -0500)
Introduced in commit a8d8ecb.  Spotted by Coverity.

Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Benoit Canet <benoit@irqsave.net>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
(cherry picked from commit f25391c2a6ef1674384204265429520ea50e82bc)
Signed-off-by: Michael Roth <mdroth@linux.vnet.ibm.com>
block/qapi.c

index 5880b3e42b84c62bcf7e61b8f51b03005d92c6ad..e9007c9ae57fc84c52911a27f5303a731e73bad2 100644 (file)
@@ -471,6 +471,7 @@ static void dump_qobject(fprintf_function func_fprintf, void *f,
         case QTYPE_QERROR: {
             QString *value = qerror_human((QError *)obj);
             func_fprintf(f, "%s", qstring_get_str(value));
+            QDECREF(value);
             break;
         }
         case QTYPE_NONE: