]> git.ipfire.org Git - thirdparty/git.git/commitdiff
push: return immediately in trivial switch case
authorFelipe Contreras <felipe.contreras@gmail.com>
Mon, 31 May 2021 19:51:13 +0000 (14:51 -0500)
committerJunio C Hamano <gitster@pobox.com>
Wed, 2 Jun 2021 01:12:01 +0000 (10:12 +0900)
There's no need to break when nothing else will be executed.

Will help next patches.

Signed-off-by: Felipe Contreras <felipe.contreras@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
builtin/push.c

index e3e792c69ce9449a421f1c3c7ea929383dac4391..0aa1d0f07de51f63c59adb50969bab2d048af111 100644 (file)
@@ -257,25 +257,25 @@ static void setup_default_push_refspecs(struct remote *remote)
        default:
        case PUSH_DEFAULT_MATCHING:
                refspec_append(&rs, ":");
-               break;
+               return;
 
        case PUSH_DEFAULT_UNSPECIFIED:
        case PUSH_DEFAULT_SIMPLE:
                setup_push_simple(remote, branch, same_remote);
-               break;
+               return;
 
        case PUSH_DEFAULT_UPSTREAM:
                setup_push_upstream(remote, branch, same_remote);
-               break;
+               return;
 
        case PUSH_DEFAULT_CURRENT:
                setup_push_current(remote, branch);
-               break;
+               return;
 
        case PUSH_DEFAULT_NOTHING:
                die(_("You didn't specify any refspecs to push, and "
                    "push.default is \"nothing\"."));
-               break;
+               return;
        }
 }