]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
ublk: return unsigned from ublk_{,un}map_io()
authorCaleb Sander Mateos <csander@purestorage.com>
Sat, 8 Nov 2025 04:23:16 +0000 (21:23 -0700)
committerJens Axboe <axboe@kernel.dk>
Tue, 11 Nov 2025 14:57:20 +0000 (07:57 -0700)
ublk_map_io() and ublk_unmap_io() never return negative values, and
their return values are stored in variables of type unsigned. Clarify
that they can't fail by making their return types unsigned.

Signed-off-by: Caleb Sander Mateos <csander@purestorage.com>
Reviewed-by: Ming Lei <ming.lei@redhat.com>
Signed-off-by: Jens Axboe <axboe@kernel.dk>
drivers/block/ublk_drv.c

index 30e798f062ef29a9726748135bc1541e754260cc..75f210523e52bbd286f3c281895fa450e7aec1ff 100644 (file)
@@ -963,8 +963,9 @@ static inline bool ublk_need_unmap_req(const struct request *req)
               (req_op(req) == REQ_OP_READ || req_op(req) == REQ_OP_DRV_IN);
 }
 
-static int ublk_map_io(const struct ublk_queue *ubq, const struct request *req,
-                      const struct ublk_io *io)
+static unsigned int ublk_map_io(const struct ublk_queue *ubq,
+                               const struct request *req,
+                               const struct ublk_io *io)
 {
        const unsigned int rq_bytes = blk_rq_bytes(req);
 
@@ -986,7 +987,7 @@ static int ublk_map_io(const struct ublk_queue *ubq, const struct request *req,
        return rq_bytes;
 }
 
-static int ublk_unmap_io(bool need_map,
+static unsigned int ublk_unmap_io(bool need_map,
                const struct request *req,
                const struct ublk_io *io)
 {