]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
drm/bridge: Change parameter name of drm_atomic_bridge_chain_post_disable()
authorMaxime Ripard <mripard@kernel.org>
Thu, 13 Feb 2025 14:43:32 +0000 (15:43 +0100)
committerMaxime Ripard <mripard@kernel.org>
Wed, 19 Feb 2025 15:59:17 +0000 (16:59 +0100)
drm_atomic_bridge_chain_post_disable() disables all bridges affected by
a new commit. It takes the drm_atomic_state being committed as a
parameter.

However, that parameter name is called (and documented) as old_state,
which is pretty confusing. Let's rename that variable as state.

Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Link: https://lore.kernel.org/r/20250213-bridge-connector-v3-13-e71598f49c8f@kernel.org
Signed-off-by: Maxime Ripard <mripard@kernel.org>
drivers/gpu/drm/drm_bridge.c

index b21b43af3d1de69c1aa9a4925922e0b2f522f026..b63ec3d0b285949ebe75f28b526e2833d0e6a850 100644 (file)
@@ -583,10 +583,10 @@ void drm_atomic_bridge_chain_disable(struct drm_bridge *bridge,
 EXPORT_SYMBOL(drm_atomic_bridge_chain_disable);
 
 static void drm_atomic_bridge_call_post_disable(struct drm_bridge *bridge,
-                                               struct drm_atomic_state *old_state)
+                                               struct drm_atomic_state *state)
 {
-       if (old_state && bridge->funcs->atomic_post_disable)
-               bridge->funcs->atomic_post_disable(bridge, old_state);
+       if (state && bridge->funcs->atomic_post_disable)
+               bridge->funcs->atomic_post_disable(bridge, state);
        else if (bridge->funcs->post_disable)
                bridge->funcs->post_disable(bridge);
 }
@@ -595,7 +595,7 @@ static void drm_atomic_bridge_call_post_disable(struct drm_bridge *bridge,
  * drm_atomic_bridge_chain_post_disable - cleans up after disabling all bridges
  *                                       in the encoder chain
  * @bridge: bridge control structure
- * @old_state: old atomic state
+ * @state: atomic state being committed
  *
  * Calls &drm_bridge_funcs.atomic_post_disable (falls back on
  * &drm_bridge_funcs.post_disable) op for all the bridges in the encoder chain,
@@ -616,7 +616,7 @@ static void drm_atomic_bridge_call_post_disable(struct drm_bridge *bridge,
  * Note: the bridge passed should be the one closest to the encoder
  */
 void drm_atomic_bridge_chain_post_disable(struct drm_bridge *bridge,
-                                         struct drm_atomic_state *old_state)
+                                         struct drm_atomic_state *state)
 {
        struct drm_encoder *encoder;
        struct drm_bridge *next, *limit;
@@ -663,12 +663,12 @@ void drm_atomic_bridge_chain_post_disable(struct drm_bridge *bridge,
                                                break;
 
                                        drm_atomic_bridge_call_post_disable(next,
-                                                                           old_state);
+                                                                           state);
                                }
                        }
                }
 
-               drm_atomic_bridge_call_post_disable(bridge, old_state);
+               drm_atomic_bridge_call_post_disable(bridge, state);
 
                if (limit)
                        /* Jump all bridges that we have already post_disabled */