]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
x86/sev: Add missing RIP_REL_REF() invocations during sme_enable()
authorKevin Loughlin <kevinloughlin@google.com>
Fri, 22 Nov 2024 20:23:22 +0000 (20:23 +0000)
committerIngo Molnar <mingo@kernel.org>
Thu, 27 Feb 2025 22:01:33 +0000 (23:01 +0100)
The following commit:

  1c811d403afd ("x86/sev: Fix position dependent variable references in startup code")

introduced RIP_REL_REF() to force RIP-relative accesses to global variables,
as needed to prevent crashes during early SEV/SME startup code.

For completeness, RIP_REL_REF() should be used with additional variables during
sme_enable():

  https://lore.kernel.org/all/CAMj1kXHnA0fJu6zh634=fbJswp59kSRAbhW+ubDGj1+NYwZJ-Q@mail.gmail.com/

Access these vars with RIP_REL_REF() to prevent problem reoccurence.

Fixes: 1c811d403afd ("x86/sev: Fix position dependent variable references in startup code")
Signed-off-by: Kevin Loughlin <kevinloughlin@google.com>
Signed-off-by: Ingo Molnar <mingo@kernel.org>
Reviewed-by: Ard Biesheuvel <ardb@kernel.org>
Reviewed-by: Tom Lendacky <thomas.lendacky@amd.com>
Cc: Dave Hansen <dave.hansen@linux.intel.com>
Link: https://lore.kernel.org/r/20241122202322.977678-1-kevinloughlin@google.com
arch/x86/mm/mem_encrypt_identity.c

index e6c7686f443a060cc62fdb6a82d549a1a0c9e9df..9fce5b87b8c50f6a0b203eab7625a58db7085668 100644 (file)
@@ -565,7 +565,7 @@ void __head sme_enable(struct boot_params *bp)
        }
 
        RIP_REL_REF(sme_me_mask) = me_mask;
-       physical_mask &= ~me_mask;
-       cc_vendor = CC_VENDOR_AMD;
+       RIP_REL_REF(physical_mask) &= ~me_mask;
+       RIP_REL_REF(cc_vendor) = CC_VENDOR_AMD;
        cc_set_mask(me_mask);
 }