Fix minor memory leak in pg_dump

A query used to read default ACL information from the catalogs did not
free a set of PQExpBuffer.

Oversight in commit e2090d9, so backpatch down to 9.6.

Author: Jie Zhang
Reviewed-by: Sawada Masahiko
Discussion: https://postgr.es/m/05bcbc5857f948efa0b451b85a48ae10@G08CNEXMBPEKD06.g08.fujitsu.local
Backpatch-through: 9.6

diff --git a/src/bin/pg_dump/pg_dump.c b/src/bin/pg_dump/pg_dump.c
index ab82e0d0f05bf8058d8f72878c89dbbab13af8e9..47acade13bf7a07c9a16c1bd745289bef29ac5bd 100644 (file)
--- a/src/bin/pg_dump/pg_dump.c
+++ b/src/bin/pg_dump/pg_dump.c
@@ -9432,6 +9432,11 @@ getDefaultACLs(Archive *fout, int *numDefaultACLs)
                                                  racl_subquery->data,
                                                  initacl_subquery->data,
                                                  initracl_subquery->data);
+
+               destroyPQExpBuffer(acl_subquery);
+               destroyPQExpBuffer(racl_subquery);
+               destroyPQExpBuffer(initacl_subquery);
+               destroyPQExpBuffer(initracl_subquery);
        }
        else
        {