]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
perf test probe_vfs_getname: Add regex for searching probe line
authorLeo Yan <leo.yan@arm.com>
Mon, 19 May 2025 08:27:55 +0000 (09:27 +0100)
committerArnaldo Carvalho de Melo <acme@redhat.com>
Tue, 20 May 2025 15:50:10 +0000 (12:50 -0300)
Since commit 611851010c74046c ("fs: dedup handling of struct filename
init and refcounts bumps"), the kernel has been refactored to use a new
inline function initname(), moving name initialization into it.

As a result, the perf probe test can no longer find the source line that
matches the defined regular expressions. This causes the script to fail
when attempting to add probes.

Add a regular expression to search for the call site of initname(). This
provides a valid source line number for adding the probe. Keeps the
older regular expressions for passing test on older kernels.

Fixes: 611851010c74046c ("fs: dedup handling of struct filename init and refcounts bumps")
Suggested-by: Arnaldo Carvalho de Melo <acme@kernel.org>
Signed-off-by: Leo Yan <leo.yan@arm.com>
Tested-by: Arnaldo Carvalho de Melo <acme@redhat.com>
Cc: Adrian Hunter <adrian.hunter@intel.com>
Cc: Christian Brauner <brauner@kernel.org>
Cc: Ian Rogers <irogers@google.com>
Cc: Jakub Brnak <jbrnak@redhat.com>
Cc: Jiri Olsa <jolsa@kernel.org>
Cc: Kan Liang <kan.liang@linux.intel.com>
Cc: Mateusz Guzik <mjguzik@gmail.com>
Cc: Namhyung Kim <namhyung@kernel.org>
Link: https://lore.kernel.org/r/20250519082755.1669187-1-leo.yan@arm.com
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
tools/perf/tests/shell/lib/probe_vfs_getname.sh

index 89f72a4c818c712bb7b8e5af54122620d890f03a..58debce9ab42a9f09dd900f835e0d52f48047617 100644 (file)
@@ -13,8 +13,16 @@ cleanup_probe_vfs_getname() {
 add_probe_vfs_getname() {
        add_probe_verbose=$1
        if [ $had_vfs_getname -eq 1 ] ; then
-               result_filename_re="[[:space:]]+([[:digit:]]+)[[:space:]]+result->uptr.*"
-               line=$(perf probe -L getname_flags 2>&1 | grep -E "$result_filename_re" | sed -r "s/$result_filename_re/\1/")
+               result_initname_re="[[:space:]]+([[:digit:]]+)[[:space:]]+initname.*"
+               line=$(perf probe -L getname_flags 2>&1 | grep -E "$result_initname_re" | sed -r "s/$result_initname_re/\1/")
+
+               # Search the old regular expressions so that this will
+               # pass on older kernels as well.
+               if [ -z "$line" ] ; then
+                       result_filename_re="[[:space:]]+([[:digit:]]+)[[:space:]]+result->uptr.*"
+                       line=$(perf probe -L getname_flags 2>&1 | grep -E "$result_filename_re" | sed -r "s/$result_filename_re/\1/")
+               fi
+
                if [ -z "$line" ] ; then
                        result_aname_re="[[:space:]]+([[:digit:]]+)[[:space:]]+result->aname = NULL;"
                        line=$(perf probe -L getname_flags 2>&1 | grep -E "$result_aname_re" | sed -r "s/$result_aname_re/\1/")