]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
watchdog: rzv2h: Improve error strings and add newlines
authorLad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
Wed, 20 Aug 2025 20:23:22 +0000 (21:23 +0100)
committerWim Van Sebroeck <wim@linux-watchdog.org>
Fri, 12 Sep 2025 16:06:31 +0000 (18:06 +0200)
Update rzv2h_wdt_probe() to provide clearer error strings when retrieving
the pclk, oscclk, and reset controller, and append missing newline
characters to dev_err_probe() and dev_warn() calls for proper log
formatting.

Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
Reviewed-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
Reviewed-by: Guenter Roeck <linux@roeck-us.net>
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
Signed-off-by: Wim Van Sebroeck <wim@linux-watchdog.org>
drivers/watchdog/rzv2h_wdt.c

index ee3ed5a6d98eaeef966a6caea9d019c9047593ad..2027795f212e2c386f11ae96f9ffc56ad611d499 100644 (file)
@@ -296,16 +296,16 @@ static int rzv2h_wdt_probe(struct platform_device *pdev)
 
        priv->pclk = devm_clk_get_prepared(dev, "pclk");
        if (IS_ERR(priv->pclk))
-               return dev_err_probe(dev, PTR_ERR(priv->pclk), "no pclk");
+               return dev_err_probe(dev, PTR_ERR(priv->pclk), "Failed to get pclk\n");
 
        priv->oscclk = devm_clk_get_optional_prepared(dev, "oscclk");
        if (IS_ERR(priv->oscclk))
-               return dev_err_probe(dev, PTR_ERR(priv->oscclk), "no oscclk");
+               return dev_err_probe(dev, PTR_ERR(priv->oscclk), "Failed to get oscclk\n");
 
        priv->rstc = devm_reset_control_get_optional_exclusive(dev, NULL);
        if (IS_ERR(priv->rstc))
                return dev_err_probe(dev, PTR_ERR(priv->rstc),
-                                    "failed to get cpg reset");
+                                    "Failed to get cpg reset\n");
 
        switch (priv->of_data->count_source) {
        case COUNT_SOURCE_LOCO:
@@ -343,7 +343,7 @@ static int rzv2h_wdt_probe(struct platform_device *pdev)
 
        ret = watchdog_init_timeout(&priv->wdev, 0, dev);
        if (ret)
-               dev_warn(dev, "Specified timeout invalid, using default");
+               dev_warn(dev, "Specified timeout invalid, using default\n");
 
        return devm_watchdog_register_device(dev, &priv->wdev);
 }