hwhdr: fix segfault when RAW_MAC is NULL

This fixes a segfault when RAW_MAC key is NULL in MAC2STR plugin.

Signed-off-by: Pierre Chifflier <chifflier@inl.fr>
Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>

diff --git a/filter/ulogd_filter_HWHDR.c b/filter/ulogd_filter_HWHDR.c
index cecd3e2785418834fa421b7530bcb53f4b88b03e..327b5fedf34d20893b6821f390d4a5308eea31cd 100644 (file)
--- a/filter/ulogd_filter_HWHDR.c
+++ b/filter/ulogd_filter_HWHDR.c
@@ -174,7 +174,7 @@ static int interp_mac2str(struct ulogd_pluginstance *pi)
                        return fret;
        }
 
-       if (!pp_is_valid(inp, KEY_RAW_MAC)) {
+       if (pp_is_valid(inp, KEY_RAW_MAC)) {
                if (GET_VALUE(inp, KEY_RAW_MAC_ADDRLEN).ui16 == ETH_ALEN) {
                        ret[KEY_MAC_TYPE].u.value.ui16 = ARPHRD_ETHER;
                        ret[KEY_MAC_TYPE].flags |= ULOGD_RETF_VALID;