]> git.ipfire.org Git - thirdparty/squid.git/commitdiff
ext_lm_group_acl: Improved username handling (#884)
authorNikita <32056979+Roo4L@users.noreply.github.com>
Fri, 13 Aug 2021 21:50:07 +0000 (21:50 +0000)
committerSquid Anubis <squid-anubis@squid-cache.org>
Sat, 14 Aug 2021 23:03:53 +0000 (23:03 +0000)
Ensure that NTDomain is terminated even if UserName is long.
It happened to be terminated in the current code, but only by accident.

src/acl/external/LM_group/ext_lm_group_acl.cc

index 30490e2a77d4fcc980aaeb447f545435d4fc38d2..c6ca3fcaeea8ca0b0ab0d8d1f2a6dca5e56488da 100644 (file)
@@ -336,7 +336,7 @@ Valid_Global_Groups(char *UserName, const char **Groups)
     DWORD i;
     DWORD dwTotalCount = 0;
 
-    strncpy(NTDomain, UserName, sizeof(NTDomain));
+    xstrncpy(NTDomain, UserName, sizeof(NTDomain));
 
     for (j = 0; j < strlen(NTV_VALID_DOMAIN_SEPARATOR); ++j) {
         if ((domain_qualify = strchr(NTDomain, NTV_VALID_DOMAIN_SEPARATOR[j])) != NULL)