]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
RDMA/mlx5: Use correct device num_ports when modify DC
authorMark Zhang <markzhang@nvidia.com>
Thu, 20 Apr 2023 01:39:06 +0000 (04:39 +0300)
committerJason Gunthorpe <jgg@nvidia.com>
Fri, 21 Apr 2023 15:36:47 +0000 (12:36 -0300)
Just like other QP types, when modify DC, the port_num should be compared
with dev->num_ports, instead of HCA_CAP.num_ports.  Otherwise Multi-port
vHCA on DC may not work.

Fixes: 776a3906b692 ("IB/mlx5: Add support for DC target QP")
Link: https://lore.kernel.org/r/20230420013906.1244185-1-markzhang@nvidia.com
Signed-off-by: Mark Zhang <markzhang@nvidia.com>
Reviewed-by: Maor Gottlieb <maorg@nvidia.com>
Signed-off-by: Jason Gunthorpe <jgg@nvidia.com>
drivers/infiniband/hw/mlx5/qp.c

index 1093d3a0ed432dfeef6ed366af52a07917128f38..70ca8ffa9256b1d11a48bbc5d50a6506a5813671 100644 (file)
@@ -4493,7 +4493,7 @@ static int mlx5_ib_modify_dct(struct ib_qp *ibqp, struct ib_qp_attr *attr,
                        return -EINVAL;
 
                if (attr->port_num == 0 ||
-                   attr->port_num > MLX5_CAP_GEN(dev->mdev, num_ports)) {
+                   attr->port_num > dev->num_ports) {
                        mlx5_ib_dbg(dev, "invalid port number %d. number of ports is %d\n",
                                    attr->port_num, dev->num_ports);
                        return -EINVAL;