]> git.ipfire.org Git - thirdparty/public-inbox.git/commitdiff
t/pop3d: try fixing "APOP UUID\@$mailbox w/ STLS" test master
authorEric Wong <e@80x24.org>
Mon, 10 Nov 2025 03:47:08 +0000 (03:47 +0000)
committerEric Wong <e@80x24.org>
Tue, 11 Nov 2025 21:02:34 +0000 (21:02 +0000)
I would've thought the ping-ponging of making a new POP3
connection and enabling STARTTLS was enough to trigger the
previous connection to close and unlock the maildrop.  In most
test runs, that appeared sufficient, but occasional failures
still happened.

The diagnostics added a few weeks ago reveals a
"[IN-USE] unable to lock maildrop" message seen by Net::POP3,
so lets try calling Net::POP3->quit on the client to explicitly
trigger ->unlock_mailbox on the server side and hope these
occasional test failures go away.

Followup-to: f4216637 (t/pop3d: add diagnostics on APOP after STLS failure, 2025-10-22)
t/pop3d.t

index 10eac41c49609839fff3b8d58f960c0c7e97a184..b69a18084fad50d48c09b71c6d7a2630e4a239c7 100644 (file)
--- a/t/pop3d.t
+++ b/t/pop3d.t
@@ -242,6 +242,7 @@ EOF
                        'TOP numlines=1');
 
                $msg = $np3->top(2, 10000);
+               ok $np3->quit, 'QUIT works after TOP'; # needed for later APOP?
                $msg = join('', @$msg);
                $msg =~ s/\r\n/\n/g;
                is_deeply(PublicInbox::Eml->new($msg), $patch,