]> git.ipfire.org Git - people/arne_f/kernel.git/commitdiff
scsi: megaraid: silence a static checker bug
authorDan Carpenter <dan.carpenter@oracle.com>
Thu, 3 May 2018 10:54:32 +0000 (13:54 +0300)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 3 Aug 2018 05:55:23 +0000 (07:55 +0200)
[ Upstream commit 27e833dabab74ee665e487e291c9afc6d71effba ]

If we had more than 32 megaraid cards then it would cause memory
corruption.  That's not likely, of course, but it's handy to enforce it
and make the static checker happy.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
Signed-off-by: Sasha Levin <alexander.levin@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/scsi/megaraid.c

index 9d05302a3bcd503f1d21d1c453c68a64ace13024..19bffe0b2cc0a3d63328efd1e96b4bfe3c423b10 100644 (file)
@@ -4197,6 +4197,9 @@ megaraid_probe_one(struct pci_dev *pdev, const struct pci_device_id *id)
        int irq, i, j;
        int error = -ENODEV;
 
+       if (hba_count >= MAX_CONTROLLERS)
+               goto out;
+
        if (pci_enable_device(pdev))
                goto out;
        pci_set_master(pdev);