]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
wifi: rtw88: 8821a/8812a: Set ptct_efuse_size to 0
authorBitterblue Smith <rtl8821cerfe2@gmail.com>
Wed, 18 Dec 2024 00:16:11 +0000 (02:16 +0200)
committerPing-Ke Shih <pkshih@realtek.com>
Mon, 23 Dec 2024 07:58:35 +0000 (15:58 +0800)
Some RTL8812AU devices fail to probe:

[   12.478774] rtw_8812au 1-1.3:1.0: failed to dump efuse logical map
[   12.487712] rtw_8812au 1-1.3:1.0: failed to setup chip efuse info
[   12.487742] rtw_8812au 1-1.3:1.0: failed to setup chip information
[   12.491077] rtw_8812au: probe of 1-1.3:1.0 failed with error -22

It turns out these chips don't need to "protect" any bytes at the end of
the efuse.

The original value of 96 was copied from rtw8821c.c.

No one reported any failures with RTL8821AU yet, but the vendor driver
uses the same efuse reading code for both chips.

Signed-off-by: Bitterblue Smith <rtl8821cerfe2@gmail.com>
Acked-by: Ping-Ke Shih <pkshih@realtek.com>
Signed-off-by: Ping-Ke Shih <pkshih@realtek.com>
Link: https://patch.msgid.link/1a477adb-60c3-463c-b158-3f86c94cb821@gmail.com
drivers/net/wireless/realtek/rtw88/rtw8812a.c
drivers/net/wireless/realtek/rtw88/rtw8821a.c

index d8f0ed70777f317d1084fd4ac25dc6156784d0b6..21795286a1a0637f84744b4fccb1e704616c3ea0 100644 (file)
@@ -1027,7 +1027,7 @@ const struct rtw_chip_info rtw8812a_hw_spec = {
        .rx_buf_desc_sz = 8,
        .phy_efuse_size = 512,
        .log_efuse_size = 512,
-       .ptct_efuse_size = 96 + 1, /* TODO or just 18? */
+       .ptct_efuse_size = 0,
        .txff_size = 131072,
        .rxff_size = 16128,
        .rsvd_drv_pg_num = 9,
index db242c9ad68f561a5a2188bea5a90bf48fd03dfb..dafab2af33bc2ef196af436121ae726447bd2768 100644 (file)
@@ -1118,7 +1118,7 @@ const struct rtw_chip_info rtw8821a_hw_spec = {
        .rx_buf_desc_sz = 8,
        .phy_efuse_size = 512,
        .log_efuse_size = 512,
-       .ptct_efuse_size = 96 + 1, /* TODO or just 18? */
+       .ptct_efuse_size = 0,
        .txff_size = 65536,
        .rxff_size = 16128,
        .rsvd_drv_pg_num = 8,