]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
mm/damon/tests/core-kunit: handle alloc failures in damon_test_set_regions()
authorSeongJae Park <sj@kernel.org>
Sat, 1 Nov 2025 18:20:04 +0000 (11:20 -0700)
committerAndrew Morton <akpm@linux-foundation.org>
Mon, 17 Nov 2025 01:28:32 +0000 (17:28 -0800)
damon_test_set_regions() is assuming all dynamic memory allocation in it
will succeed.  Those are indeed likely in the real use cases since those
allocations are too small to fail, but theoretically those could fail.  In
the case, inappropriate memory access can happen.  Fix it by appropriately
cleanup pre-allocated memory and skip the execution of the remaining tests
in the failure cases.

Link: https://lkml.kernel.org/r/20251101182021.74868-11-sj@kernel.org
Fixes: 62f409560eb2 ("mm/damon/core-test: test damon_set_regions")
Signed-off-by: SeongJae Park <sj@kernel.org>
Cc: Brendan Higgins <brendan.higgins@linux.dev>
Cc: David Gow <davidgow@google.com>
Cc: Kefeng Wang <wangkefeng.wang@huawei.com>
Cc: <stable@vger.kernel.org> [6.1+]
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
mm/damon/tests/core-kunit.h

index 96c8f1269f44bd90ba40cd32575df36a9aa12c68..e38c95f86a68fecae1bda90dfe7244a62efffaf4 100644 (file)
@@ -368,13 +368,26 @@ static void damon_test_ops_registration(struct kunit *test)
 static void damon_test_set_regions(struct kunit *test)
 {
        struct damon_target *t = damon_new_target();
-       struct damon_region *r1 = damon_new_region(4, 16);
-       struct damon_region *r2 = damon_new_region(24, 32);
+       struct damon_region *r1, *r2;
        struct damon_addr_range range = {.start = 8, .end = 28};
        unsigned long expects[] = {8, 16, 16, 24, 24, 28};
        int expect_idx = 0;
        struct damon_region *r;
 
+       if (!t)
+               kunit_skip(test, "target alloc fail");
+       r1 = damon_new_region(4, 16);
+       if (!r1) {
+               damon_free_target(t);
+               kunit_skip(test, "region alloc fail");
+       }
+       r2 = damon_new_region(24, 32);
+       if (!r2) {
+               damon_free_target(t);
+               damon_free_region(r1);
+               kunit_skip(test, "second region alloc fail");
+       }
+
        damon_add_region(r1, t);
        damon_add_region(r2, t);
        damon_set_regions(t, &range, 1, DAMON_MIN_REGION);