]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
bus: bt1-apb: Use PTR_ERR_OR_ZERO to return from request-regs method
authorSerge Semin <Sergey.Semin@baikalelectronics.ru>
Thu, 28 May 2020 14:50:47 +0000 (17:50 +0300)
committerArnd Bergmann <arnd@arndb.de>
Thu, 28 May 2020 14:56:46 +0000 (16:56 +0200)
Indeed it's more optimal to use the PTR_ERR_OR_ZERO() macro there instead
of having two return points.

Link: https://lore.kernel.org/r/20200528145050.5203-3-Sergey.Semin@baikalelectronics.ru
Signed-off-by: Serge Semin <Sergey.Semin@baikalelectronics.ru>
Cc: Alexey Malahov <Alexey.Malahov@baikalelectronics.ru>
Cc: Olof Johansson <olof@lixom.net>
Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: soc@kernel.org
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
drivers/bus/bt1-apb.c

index 59ec5e7077e8900ec92fea57de1b298f3bd2cd22..7e57fc2af745878fb8abdb40a8d9fb891aecd3fe 100644 (file)
@@ -164,12 +164,10 @@ static int bt1_apb_request_regs(struct bt1_apb *apb)
        }
 
        apb->res = devm_platform_ioremap_resource_byname(pdev, "nodev");
-       if (IS_ERR(apb->res)) {
+       if (IS_ERR(apb->res))
                dev_err(apb->dev, "Couldn't map reserved region\n");
-               return PTR_ERR(apb->res);
-       }
 
-       return 0;
+       return PTR_ERR_OR_ZERO(apb->res);
 }
 
 static int bt1_apb_request_rst(struct bt1_apb *apb)