]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
pinctrl: intel: copy communities using devm_kmemdup_array()
authorRaag Jadav <raag.jadav@intel.com>
Wed, 12 Feb 2025 06:25:06 +0000 (11:55 +0530)
committerAndy Shevchenko <andriy.shevchenko@linux.intel.com>
Mon, 24 Feb 2025 10:08:52 +0000 (12:08 +0200)
Copy communities using devm_kmemdup_array() instead of doing it manually.

Signed-off-by: Raag Jadav <raag.jadav@intel.com>
Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
drivers/pinctrl/intel/pinctrl-intel.c

index 527e4b87ae52e85b6f2997c37b7f5b24d3f62964..33cb918ed8068c562365dafa81cae8e72e1ea213 100644 (file)
@@ -1577,8 +1577,8 @@ int intel_pinctrl_probe(struct platform_device *pdev,
         * to the registers.
         */
        pctrl->ncommunities = pctrl->soc->ncommunities;
-       pctrl->communities = devm_kcalloc(dev, pctrl->ncommunities,
-                                         sizeof(*pctrl->communities), GFP_KERNEL);
+       pctrl->communities = devm_kmemdup_array(dev, pctrl->soc->communities, pctrl->ncommunities,
+                                               sizeof(*pctrl->soc->communities), GFP_KERNEL);
        if (!pctrl->communities)
                return -ENOMEM;
 
@@ -1588,8 +1588,6 @@ int intel_pinctrl_probe(struct platform_device *pdev,
                u32 offset;
                u32 value;
 
-               *community = pctrl->soc->communities[i];
-
                regs = devm_platform_ioremap_resource(pdev, community->barno);
                if (IS_ERR(regs))
                        return PTR_ERR(regs);