]> git.ipfire.org Git - thirdparty/openvpn.git/commitdiff
Do not hard-code windows systemroot in env_block
authorSelva Nair <selva.nair@gmail.com>
Fri, 13 Nov 2015 02:41:27 +0000 (21:41 -0500)
committerGert Doering <gert@greenie.muc.de>
Fri, 13 Nov 2015 15:28:41 +0000 (16:28 +0100)
FWIW, fixes trac #500

Signed-off-by: Selva Nair <selva.nair@gmail.com>
Acked-by: Gert Doering <gert@greenie.muc.de>
Message-Id: <1447382487-26031-1-git-send-email-selva.nair@gmail.com>
URL: http://article.gmane.org/gmane.network.openvpn.devel/10492
Signed-off-by: Gert Doering <gert@greenie.muc.de>
src/openvpn/win32.c

index 7c89a5a9ce3a0785eb78dfe028f04514412ff258..d06b41f1641b9e61a84a00e127d13936c081c097 100644 (file)
@@ -763,7 +763,12 @@ win_safe_filename (const char *fn)
 static char *
 env_block (const struct env_set *es)
 {
-  char * force_path = "PATH=C:\\Windows\\System32;C:\\WINDOWS;C:\\WINDOWS\\System32\\Wbem";
+  char force_path[256];
+  char *sysroot = get_win_sys_path();
+
+  if (!openvpn_snprintf(force_path, sizeof(force_path), "PATH=%s\\System32;%s;%s\\System32\\Wbem",
+                        sysroot, sysroot, sysroot))
+    msg(M_WARN, "env_block: default path truncated to %s", force_path);
 
   if (es)
     {