]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
ssb: use new GPIO line value setter callbacks
authorBartosz Golaszewski <bartosz.golaszewski@linaro.org>
Tue, 10 Jun 2025 12:39:42 +0000 (14:39 +0200)
committerJohannes Berg <johannes.berg@intel.com>
Fri, 20 Jun 2025 08:55:19 +0000 (10:55 +0200)
struct gpio_chip now has callbacks for setting line values that return
an integer, allowing to indicate failures. Convert the driver to using
them.

Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
Link: https://patch.msgid.link/20250610-gpiochip-set-rv-ssb-v1-1-0bee5b45b411@linaro.org
Signed-off-by: Johannes Berg <johannes.berg@intel.com>
drivers/ssb/driver_gpio.c

index f9426a58665365e3f85bc6515049f9c551a78589..14ad57954a662383ec0f0741835da55cbd21a44e 100644 (file)
@@ -45,12 +45,14 @@ static int ssb_gpio_chipco_get_value(struct gpio_chip *chip, unsigned int gpio)
        return !!ssb_chipco_gpio_in(&bus->chipco, 1 << gpio);
 }
 
-static void ssb_gpio_chipco_set_value(struct gpio_chip *chip, unsigned int gpio,
-                                     int value)
+static int ssb_gpio_chipco_set_value(struct gpio_chip *chip, unsigned int gpio,
+                                    int value)
 {
        struct ssb_bus *bus = gpiochip_get_data(chip);
 
        ssb_chipco_gpio_out(&bus->chipco, 1 << gpio, value ? 1 << gpio : 0);
+
+       return 0;
 }
 
 static int ssb_gpio_chipco_direction_input(struct gpio_chip *chip,
@@ -223,7 +225,7 @@ static int ssb_gpio_chipco_init(struct ssb_bus *bus)
        chip->request           = ssb_gpio_chipco_request;
        chip->free              = ssb_gpio_chipco_free;
        chip->get               = ssb_gpio_chipco_get_value;
-       chip->set               = ssb_gpio_chipco_set_value;
+       chip->set_rv            = ssb_gpio_chipco_set_value;
        chip->direction_input   = ssb_gpio_chipco_direction_input;
        chip->direction_output  = ssb_gpio_chipco_direction_output;
 #if IS_ENABLED(CONFIG_SSB_EMBEDDED)