]> git.ipfire.org Git - thirdparty/kernel/stable-queue.git/commitdiff
Drop ocfs2-strict-bound-check-before-memcmp-in-ocfs2_xattr_find_entry.patch
authorSasha Levin <sashal@kernel.org>
Thu, 19 Sep 2024 00:08:29 +0000 (20:08 -0400)
committerSasha Levin <sashal@kernel.org>
Thu, 19 Sep 2024 00:08:29 +0000 (20:08 -0400)
Signed-off-by: Sasha Levin <sashal@kernel.org>
14 files changed:
queue-4.19/ocfs2-strict-bound-check-before-memcmp-in-ocfs2_xattr_find_entry.patch [deleted file]
queue-4.19/series
queue-5.10/ocfs2-strict-bound-check-before-memcmp-in-ocfs2_xattr_find_entry.patch [deleted file]
queue-5.10/series
queue-5.15/ocfs2-strict-bound-check-before-memcmp-in-ocfs2_xattr_find_entry.patch [deleted file]
queue-5.15/series
queue-5.4/ocfs2-strict-bound-check-before-memcmp-in-ocfs2_xattr_find_entry.patch [deleted file]
queue-5.4/series
queue-6.1/ocfs2-strict-bound-check-before-memcmp-in-ocfs2_xattr_find_entry.patch [deleted file]
queue-6.1/series
queue-6.10/ocfs2-strict-bound-check-before-memcmp-in-ocfs2_xattr_find_entry.patch [deleted file]
queue-6.10/series
queue-6.6/ocfs2-strict-bound-check-before-memcmp-in-ocfs2_xattr_find_entry.patch [deleted file]
queue-6.6/series

diff --git a/queue-4.19/ocfs2-strict-bound-check-before-memcmp-in-ocfs2_xattr_find_entry.patch b/queue-4.19/ocfs2-strict-bound-check-before-memcmp-in-ocfs2_xattr_find_entry.patch
deleted file mode 100644 (file)
index 456237d..0000000
+++ /dev/null
@@ -1,62 +0,0 @@
-From af77c4fc1871847b528d58b7fdafb4aa1f6a9262 Mon Sep 17 00:00:00 2001
-From: Ferry Meng <mengferry@linux.alibaba.com>
-Date: Mon, 20 May 2024 10:40:24 +0800
-Subject: ocfs2: strict bound check before memcmp in ocfs2_xattr_find_entry()
-
-From: Ferry Meng <mengferry@linux.alibaba.com>
-
-commit af77c4fc1871847b528d58b7fdafb4aa1f6a9262 upstream.
-
-xattr in ocfs2 maybe 'non-indexed', which saved with additional space
-requested.  It's better to check if the memory is out of bound before
-memcmp, although this possibility mainly comes from crafted poisonous
-images.
-
-Link: https://lkml.kernel.org/r/20240520024024.1976129-2-joseph.qi@linux.alibaba.com
-Signed-off-by: Ferry Meng <mengferry@linux.alibaba.com>
-Signed-off-by: Joseph Qi <joseph.qi@linux.alibaba.com>
-Reported-by: lei lu <llfamsec@gmail.com>
-Reviewed-by: Joseph Qi <joseph.qi@linux.alibaba.com>
-Cc: Changwei Ge <gechangwei@live.cn>
-Cc: Gang He <ghe@suse.com>
-Cc: Joel Becker <jlbec@evilplan.org>
-Cc: Jun Piao <piaojun@huawei.com>
-Cc: Junxiao Bi <junxiao.bi@oracle.com>
-Cc: Mark Fasheh <mark@fasheh.com>
-Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
-Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
----
- fs/ocfs2/xattr.c |   15 ++++++++++-----
- 1 file changed, 10 insertions(+), 5 deletions(-)
-
---- a/fs/ocfs2/xattr.c
-+++ b/fs/ocfs2/xattr.c
-@@ -1082,7 +1082,7 @@ static int ocfs2_xattr_find_entry(int na
- {
-       struct ocfs2_xattr_entry *entry;
-       size_t name_len;
--      int i, cmp = 1;
-+      int i, name_offset, cmp = 1;
-       if (name == NULL)
-               return -EINVAL;
-@@ -1093,10 +1093,15 @@ static int ocfs2_xattr_find_entry(int na
-               cmp = name_index - ocfs2_xattr_get_type(entry);
-               if (!cmp)
-                       cmp = name_len - entry->xe_name_len;
--              if (!cmp)
--                      cmp = memcmp(name, (xs->base +
--                                   le16_to_cpu(entry->xe_name_offset)),
--                                   name_len);
-+              if (!cmp) {
-+                      name_offset = le16_to_cpu(entry->xe_name_offset);
-+                      if ((xs->base + name_offset + name_len) > xs->end) {
-+                              ocfs2_error(inode->i_sb,
-+                                          "corrupted xattr entries");
-+                              return -EFSCORRUPTED;
-+                      }
-+                      cmp = memcmp(name, (xs->base + name_offset), name_len);
-+              }
-               if (cmp == 0)
-                       break;
-               entry += 1;
index f82422bd0691b607e87950e40b7eefa9e77ad8e1..9ccee0e6e490b304c4f1d3fdbb24fa53919e1c41 100644 (file)
@@ -12,4 +12,3 @@ net-dpaa-pad-packets-to-eth_zlen.patch
 soundwire-stream-revert-soundwire-stream-fix-programming-slave-ports-for-non-continous-port-maps.patch
 selftests-vm-remove-call-to-ksft_set_plan.patch
 selftests-kcmp-remove-call-to-ksft_set_plan.patch
-ocfs2-strict-bound-check-before-memcmp-in-ocfs2_xattr_find_entry.patch
diff --git a/queue-5.10/ocfs2-strict-bound-check-before-memcmp-in-ocfs2_xattr_find_entry.patch b/queue-5.10/ocfs2-strict-bound-check-before-memcmp-in-ocfs2_xattr_find_entry.patch
deleted file mode 100644 (file)
index 71f4312..0000000
+++ /dev/null
@@ -1,62 +0,0 @@
-From af77c4fc1871847b528d58b7fdafb4aa1f6a9262 Mon Sep 17 00:00:00 2001
-From: Ferry Meng <mengferry@linux.alibaba.com>
-Date: Mon, 20 May 2024 10:40:24 +0800
-Subject: ocfs2: strict bound check before memcmp in ocfs2_xattr_find_entry()
-
-From: Ferry Meng <mengferry@linux.alibaba.com>
-
-commit af77c4fc1871847b528d58b7fdafb4aa1f6a9262 upstream.
-
-xattr in ocfs2 maybe 'non-indexed', which saved with additional space
-requested.  It's better to check if the memory is out of bound before
-memcmp, although this possibility mainly comes from crafted poisonous
-images.
-
-Link: https://lkml.kernel.org/r/20240520024024.1976129-2-joseph.qi@linux.alibaba.com
-Signed-off-by: Ferry Meng <mengferry@linux.alibaba.com>
-Signed-off-by: Joseph Qi <joseph.qi@linux.alibaba.com>
-Reported-by: lei lu <llfamsec@gmail.com>
-Reviewed-by: Joseph Qi <joseph.qi@linux.alibaba.com>
-Cc: Changwei Ge <gechangwei@live.cn>
-Cc: Gang He <ghe@suse.com>
-Cc: Joel Becker <jlbec@evilplan.org>
-Cc: Jun Piao <piaojun@huawei.com>
-Cc: Junxiao Bi <junxiao.bi@oracle.com>
-Cc: Mark Fasheh <mark@fasheh.com>
-Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
-Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
----
- fs/ocfs2/xattr.c |   15 ++++++++++-----
- 1 file changed, 10 insertions(+), 5 deletions(-)
-
---- a/fs/ocfs2/xattr.c
-+++ b/fs/ocfs2/xattr.c
-@@ -1074,7 +1074,7 @@ static int ocfs2_xattr_find_entry(int na
- {
-       struct ocfs2_xattr_entry *entry;
-       size_t name_len;
--      int i, cmp = 1;
-+      int i, name_offset, cmp = 1;
-       if (name == NULL)
-               return -EINVAL;
-@@ -1085,10 +1085,15 @@ static int ocfs2_xattr_find_entry(int na
-               cmp = name_index - ocfs2_xattr_get_type(entry);
-               if (!cmp)
-                       cmp = name_len - entry->xe_name_len;
--              if (!cmp)
--                      cmp = memcmp(name, (xs->base +
--                                   le16_to_cpu(entry->xe_name_offset)),
--                                   name_len);
-+              if (!cmp) {
-+                      name_offset = le16_to_cpu(entry->xe_name_offset);
-+                      if ((xs->base + name_offset + name_len) > xs->end) {
-+                              ocfs2_error(inode->i_sb,
-+                                          "corrupted xattr entries");
-+                              return -EFSCORRUPTED;
-+                      }
-+                      cmp = memcmp(name, (xs->base + name_offset), name_len);
-+              }
-               if (cmp == 0)
-                       break;
-               entry += 1;
index d61e95a132acc06e52b54e692ab7eadf09bdedc9..fdaa0d5ae37c85b8a8f7a295adff12ad021e372f 100644 (file)
@@ -26,4 +26,3 @@ spi-nxp-fspi-fix-the-kasan-report-out-of-bounds-bug.patch
 soundwire-stream-revert-soundwire-stream-fix-programming-slave-ports-for-non-continous-port-maps.patch
 asoc-meson-axg-card-fix-use-after-free.patch
 dma-buf-heaps-fix-off-by-one-in-cma-heap-fault-handler.patch
-ocfs2-strict-bound-check-before-memcmp-in-ocfs2_xattr_find_entry.patch
diff --git a/queue-5.15/ocfs2-strict-bound-check-before-memcmp-in-ocfs2_xattr_find_entry.patch b/queue-5.15/ocfs2-strict-bound-check-before-memcmp-in-ocfs2_xattr_find_entry.patch
deleted file mode 100644 (file)
index 03d487f..0000000
+++ /dev/null
@@ -1,62 +0,0 @@
-From af77c4fc1871847b528d58b7fdafb4aa1f6a9262 Mon Sep 17 00:00:00 2001
-From: Ferry Meng <mengferry@linux.alibaba.com>
-Date: Mon, 20 May 2024 10:40:24 +0800
-Subject: ocfs2: strict bound check before memcmp in ocfs2_xattr_find_entry()
-
-From: Ferry Meng <mengferry@linux.alibaba.com>
-
-commit af77c4fc1871847b528d58b7fdafb4aa1f6a9262 upstream.
-
-xattr in ocfs2 maybe 'non-indexed', which saved with additional space
-requested.  It's better to check if the memory is out of bound before
-memcmp, although this possibility mainly comes from crafted poisonous
-images.
-
-Link: https://lkml.kernel.org/r/20240520024024.1976129-2-joseph.qi@linux.alibaba.com
-Signed-off-by: Ferry Meng <mengferry@linux.alibaba.com>
-Signed-off-by: Joseph Qi <joseph.qi@linux.alibaba.com>
-Reported-by: lei lu <llfamsec@gmail.com>
-Reviewed-by: Joseph Qi <joseph.qi@linux.alibaba.com>
-Cc: Changwei Ge <gechangwei@live.cn>
-Cc: Gang He <ghe@suse.com>
-Cc: Joel Becker <jlbec@evilplan.org>
-Cc: Jun Piao <piaojun@huawei.com>
-Cc: Junxiao Bi <junxiao.bi@oracle.com>
-Cc: Mark Fasheh <mark@fasheh.com>
-Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
-Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
----
- fs/ocfs2/xattr.c |   15 ++++++++++-----
- 1 file changed, 10 insertions(+), 5 deletions(-)
-
---- a/fs/ocfs2/xattr.c
-+++ b/fs/ocfs2/xattr.c
-@@ -1072,7 +1072,7 @@ static int ocfs2_xattr_find_entry(int na
- {
-       struct ocfs2_xattr_entry *entry;
-       size_t name_len;
--      int i, cmp = 1;
-+      int i, name_offset, cmp = 1;
-       if (name == NULL)
-               return -EINVAL;
-@@ -1083,10 +1083,15 @@ static int ocfs2_xattr_find_entry(int na
-               cmp = name_index - ocfs2_xattr_get_type(entry);
-               if (!cmp)
-                       cmp = name_len - entry->xe_name_len;
--              if (!cmp)
--                      cmp = memcmp(name, (xs->base +
--                                   le16_to_cpu(entry->xe_name_offset)),
--                                   name_len);
-+              if (!cmp) {
-+                      name_offset = le16_to_cpu(entry->xe_name_offset);
-+                      if ((xs->base + name_offset + name_len) > xs->end) {
-+                              ocfs2_error(inode->i_sb,
-+                                          "corrupted xattr entries");
-+                              return -EFSCORRUPTED;
-+                      }
-+                      cmp = memcmp(name, (xs->base + name_offset), name_len);
-+              }
-               if (cmp == 0)
-                       break;
-               entry += 1;
index 14bffad7b043c32a8a9d0bab54ed8354449effc4..b777983bcd58b0667110cafb28b561dc76062d91 100644 (file)
@@ -42,4 +42,3 @@ spi-nxp-fspi-fix-the-kasan-report-out-of-bounds-bug.patch
 soundwire-stream-revert-soundwire-stream-fix-programming-slave-ports-for-non-continous-port-maps.patch
 dma-buf-heaps-fix-off-by-one-in-cma-heap-fault-handler.patch
 asoc-meson-axg-card-fix-use-after-free.patch
-ocfs2-strict-bound-check-before-memcmp-in-ocfs2_xattr_find_entry.patch
diff --git a/queue-5.4/ocfs2-strict-bound-check-before-memcmp-in-ocfs2_xattr_find_entry.patch b/queue-5.4/ocfs2-strict-bound-check-before-memcmp-in-ocfs2_xattr_find_entry.patch
deleted file mode 100644 (file)
index 71f4312..0000000
+++ /dev/null
@@ -1,62 +0,0 @@
-From af77c4fc1871847b528d58b7fdafb4aa1f6a9262 Mon Sep 17 00:00:00 2001
-From: Ferry Meng <mengferry@linux.alibaba.com>
-Date: Mon, 20 May 2024 10:40:24 +0800
-Subject: ocfs2: strict bound check before memcmp in ocfs2_xattr_find_entry()
-
-From: Ferry Meng <mengferry@linux.alibaba.com>
-
-commit af77c4fc1871847b528d58b7fdafb4aa1f6a9262 upstream.
-
-xattr in ocfs2 maybe 'non-indexed', which saved with additional space
-requested.  It's better to check if the memory is out of bound before
-memcmp, although this possibility mainly comes from crafted poisonous
-images.
-
-Link: https://lkml.kernel.org/r/20240520024024.1976129-2-joseph.qi@linux.alibaba.com
-Signed-off-by: Ferry Meng <mengferry@linux.alibaba.com>
-Signed-off-by: Joseph Qi <joseph.qi@linux.alibaba.com>
-Reported-by: lei lu <llfamsec@gmail.com>
-Reviewed-by: Joseph Qi <joseph.qi@linux.alibaba.com>
-Cc: Changwei Ge <gechangwei@live.cn>
-Cc: Gang He <ghe@suse.com>
-Cc: Joel Becker <jlbec@evilplan.org>
-Cc: Jun Piao <piaojun@huawei.com>
-Cc: Junxiao Bi <junxiao.bi@oracle.com>
-Cc: Mark Fasheh <mark@fasheh.com>
-Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
-Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
----
- fs/ocfs2/xattr.c |   15 ++++++++++-----
- 1 file changed, 10 insertions(+), 5 deletions(-)
-
---- a/fs/ocfs2/xattr.c
-+++ b/fs/ocfs2/xattr.c
-@@ -1074,7 +1074,7 @@ static int ocfs2_xattr_find_entry(int na
- {
-       struct ocfs2_xattr_entry *entry;
-       size_t name_len;
--      int i, cmp = 1;
-+      int i, name_offset, cmp = 1;
-       if (name == NULL)
-               return -EINVAL;
-@@ -1085,10 +1085,15 @@ static int ocfs2_xattr_find_entry(int na
-               cmp = name_index - ocfs2_xattr_get_type(entry);
-               if (!cmp)
-                       cmp = name_len - entry->xe_name_len;
--              if (!cmp)
--                      cmp = memcmp(name, (xs->base +
--                                   le16_to_cpu(entry->xe_name_offset)),
--                                   name_len);
-+              if (!cmp) {
-+                      name_offset = le16_to_cpu(entry->xe_name_offset);
-+                      if ((xs->base + name_offset + name_len) > xs->end) {
-+                              ocfs2_error(inode->i_sb,
-+                                          "corrupted xattr entries");
-+                              return -EFSCORRUPTED;
-+                      }
-+                      cmp = memcmp(name, (xs->base + name_offset), name_len);
-+              }
-               if (cmp == 0)
-                       break;
-               entry += 1;
index 4353fbe640bb2d4d131b9ee070543a104df14682..c574edd8c6e4df4c63b651096b528647921f08ad 100644 (file)
@@ -10,4 +10,3 @@ net-dpaa-pad-packets-to-eth_zlen.patch
 spi-nxp-fspi-fix-the-kasan-report-out-of-bounds-bug.patch
 soundwire-stream-revert-soundwire-stream-fix-programming-slave-ports-for-non-continous-port-maps.patch
 selftests-breakpoints-fix-a-typo-of-function-name.patch
-ocfs2-strict-bound-check-before-memcmp-in-ocfs2_xattr_find_entry.patch
diff --git a/queue-6.1/ocfs2-strict-bound-check-before-memcmp-in-ocfs2_xattr_find_entry.patch b/queue-6.1/ocfs2-strict-bound-check-before-memcmp-in-ocfs2_xattr_find_entry.patch
deleted file mode 100644 (file)
index 03d487f..0000000
+++ /dev/null
@@ -1,62 +0,0 @@
-From af77c4fc1871847b528d58b7fdafb4aa1f6a9262 Mon Sep 17 00:00:00 2001
-From: Ferry Meng <mengferry@linux.alibaba.com>
-Date: Mon, 20 May 2024 10:40:24 +0800
-Subject: ocfs2: strict bound check before memcmp in ocfs2_xattr_find_entry()
-
-From: Ferry Meng <mengferry@linux.alibaba.com>
-
-commit af77c4fc1871847b528d58b7fdafb4aa1f6a9262 upstream.
-
-xattr in ocfs2 maybe 'non-indexed', which saved with additional space
-requested.  It's better to check if the memory is out of bound before
-memcmp, although this possibility mainly comes from crafted poisonous
-images.
-
-Link: https://lkml.kernel.org/r/20240520024024.1976129-2-joseph.qi@linux.alibaba.com
-Signed-off-by: Ferry Meng <mengferry@linux.alibaba.com>
-Signed-off-by: Joseph Qi <joseph.qi@linux.alibaba.com>
-Reported-by: lei lu <llfamsec@gmail.com>
-Reviewed-by: Joseph Qi <joseph.qi@linux.alibaba.com>
-Cc: Changwei Ge <gechangwei@live.cn>
-Cc: Gang He <ghe@suse.com>
-Cc: Joel Becker <jlbec@evilplan.org>
-Cc: Jun Piao <piaojun@huawei.com>
-Cc: Junxiao Bi <junxiao.bi@oracle.com>
-Cc: Mark Fasheh <mark@fasheh.com>
-Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
-Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
----
- fs/ocfs2/xattr.c |   15 ++++++++++-----
- 1 file changed, 10 insertions(+), 5 deletions(-)
-
---- a/fs/ocfs2/xattr.c
-+++ b/fs/ocfs2/xattr.c
-@@ -1072,7 +1072,7 @@ static int ocfs2_xattr_find_entry(int na
- {
-       struct ocfs2_xattr_entry *entry;
-       size_t name_len;
--      int i, cmp = 1;
-+      int i, name_offset, cmp = 1;
-       if (name == NULL)
-               return -EINVAL;
-@@ -1083,10 +1083,15 @@ static int ocfs2_xattr_find_entry(int na
-               cmp = name_index - ocfs2_xattr_get_type(entry);
-               if (!cmp)
-                       cmp = name_len - entry->xe_name_len;
--              if (!cmp)
--                      cmp = memcmp(name, (xs->base +
--                                   le16_to_cpu(entry->xe_name_offset)),
--                                   name_len);
-+              if (!cmp) {
-+                      name_offset = le16_to_cpu(entry->xe_name_offset);
-+                      if ((xs->base + name_offset + name_len) > xs->end) {
-+                              ocfs2_error(inode->i_sb,
-+                                          "corrupted xattr entries");
-+                              return -EFSCORRUPTED;
-+                      }
-+                      cmp = memcmp(name, (xs->base + name_offset), name_len);
-+              }
-               if (cmp == 0)
-                       break;
-               entry += 1;
index 53281433b5ddb3ecfbbeaaf0ae1df24bb98ddb43..e69de29bb2d1d6434b8b29ae775ad8c2e48c5391 100644 (file)
@@ -1 +0,0 @@
-ocfs2-strict-bound-check-before-memcmp-in-ocfs2_xattr_find_entry.patch
diff --git a/queue-6.10/ocfs2-strict-bound-check-before-memcmp-in-ocfs2_xattr_find_entry.patch b/queue-6.10/ocfs2-strict-bound-check-before-memcmp-in-ocfs2_xattr_find_entry.patch
deleted file mode 100644 (file)
index be0e929..0000000
+++ /dev/null
@@ -1,62 +0,0 @@
-From af77c4fc1871847b528d58b7fdafb4aa1f6a9262 Mon Sep 17 00:00:00 2001
-From: Ferry Meng <mengferry@linux.alibaba.com>
-Date: Mon, 20 May 2024 10:40:24 +0800
-Subject: ocfs2: strict bound check before memcmp in ocfs2_xattr_find_entry()
-
-From: Ferry Meng <mengferry@linux.alibaba.com>
-
-commit af77c4fc1871847b528d58b7fdafb4aa1f6a9262 upstream.
-
-xattr in ocfs2 maybe 'non-indexed', which saved with additional space
-requested.  It's better to check if the memory is out of bound before
-memcmp, although this possibility mainly comes from crafted poisonous
-images.
-
-Link: https://lkml.kernel.org/r/20240520024024.1976129-2-joseph.qi@linux.alibaba.com
-Signed-off-by: Ferry Meng <mengferry@linux.alibaba.com>
-Signed-off-by: Joseph Qi <joseph.qi@linux.alibaba.com>
-Reported-by: lei lu <llfamsec@gmail.com>
-Reviewed-by: Joseph Qi <joseph.qi@linux.alibaba.com>
-Cc: Changwei Ge <gechangwei@live.cn>
-Cc: Gang He <ghe@suse.com>
-Cc: Joel Becker <jlbec@evilplan.org>
-Cc: Jun Piao <piaojun@huawei.com>
-Cc: Junxiao Bi <junxiao.bi@oracle.com>
-Cc: Mark Fasheh <mark@fasheh.com>
-Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
-Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
----
- fs/ocfs2/xattr.c |   15 ++++++++++-----
- 1 file changed, 10 insertions(+), 5 deletions(-)
-
---- a/fs/ocfs2/xattr.c
-+++ b/fs/ocfs2/xattr.c
-@@ -1068,7 +1068,7 @@ static int ocfs2_xattr_find_entry(int na
- {
-       struct ocfs2_xattr_entry *entry;
-       size_t name_len;
--      int i, cmp = 1;
-+      int i, name_offset, cmp = 1;
-       if (name == NULL)
-               return -EINVAL;
-@@ -1079,10 +1079,15 @@ static int ocfs2_xattr_find_entry(int na
-               cmp = name_index - ocfs2_xattr_get_type(entry);
-               if (!cmp)
-                       cmp = name_len - entry->xe_name_len;
--              if (!cmp)
--                      cmp = memcmp(name, (xs->base +
--                                   le16_to_cpu(entry->xe_name_offset)),
--                                   name_len);
-+              if (!cmp) {
-+                      name_offset = le16_to_cpu(entry->xe_name_offset);
-+                      if ((xs->base + name_offset + name_len) > xs->end) {
-+                              ocfs2_error(inode->i_sb,
-+                                          "corrupted xattr entries");
-+                              return -EFSCORRUPTED;
-+                      }
-+                      cmp = memcmp(name, (xs->base + name_offset), name_len);
-+              }
-               if (cmp == 0)
-                       break;
-               entry += 1;
index 53281433b5ddb3ecfbbeaaf0ae1df24bb98ddb43..e69de29bb2d1d6434b8b29ae775ad8c2e48c5391 100644 (file)
@@ -1 +0,0 @@
-ocfs2-strict-bound-check-before-memcmp-in-ocfs2_xattr_find_entry.patch
diff --git a/queue-6.6/ocfs2-strict-bound-check-before-memcmp-in-ocfs2_xattr_find_entry.patch b/queue-6.6/ocfs2-strict-bound-check-before-memcmp-in-ocfs2_xattr_find_entry.patch
deleted file mode 100644 (file)
index be0e929..0000000
+++ /dev/null
@@ -1,62 +0,0 @@
-From af77c4fc1871847b528d58b7fdafb4aa1f6a9262 Mon Sep 17 00:00:00 2001
-From: Ferry Meng <mengferry@linux.alibaba.com>
-Date: Mon, 20 May 2024 10:40:24 +0800
-Subject: ocfs2: strict bound check before memcmp in ocfs2_xattr_find_entry()
-
-From: Ferry Meng <mengferry@linux.alibaba.com>
-
-commit af77c4fc1871847b528d58b7fdafb4aa1f6a9262 upstream.
-
-xattr in ocfs2 maybe 'non-indexed', which saved with additional space
-requested.  It's better to check if the memory is out of bound before
-memcmp, although this possibility mainly comes from crafted poisonous
-images.
-
-Link: https://lkml.kernel.org/r/20240520024024.1976129-2-joseph.qi@linux.alibaba.com
-Signed-off-by: Ferry Meng <mengferry@linux.alibaba.com>
-Signed-off-by: Joseph Qi <joseph.qi@linux.alibaba.com>
-Reported-by: lei lu <llfamsec@gmail.com>
-Reviewed-by: Joseph Qi <joseph.qi@linux.alibaba.com>
-Cc: Changwei Ge <gechangwei@live.cn>
-Cc: Gang He <ghe@suse.com>
-Cc: Joel Becker <jlbec@evilplan.org>
-Cc: Jun Piao <piaojun@huawei.com>
-Cc: Junxiao Bi <junxiao.bi@oracle.com>
-Cc: Mark Fasheh <mark@fasheh.com>
-Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
-Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
----
- fs/ocfs2/xattr.c |   15 ++++++++++-----
- 1 file changed, 10 insertions(+), 5 deletions(-)
-
---- a/fs/ocfs2/xattr.c
-+++ b/fs/ocfs2/xattr.c
-@@ -1068,7 +1068,7 @@ static int ocfs2_xattr_find_entry(int na
- {
-       struct ocfs2_xattr_entry *entry;
-       size_t name_len;
--      int i, cmp = 1;
-+      int i, name_offset, cmp = 1;
-       if (name == NULL)
-               return -EINVAL;
-@@ -1079,10 +1079,15 @@ static int ocfs2_xattr_find_entry(int na
-               cmp = name_index - ocfs2_xattr_get_type(entry);
-               if (!cmp)
-                       cmp = name_len - entry->xe_name_len;
--              if (!cmp)
--                      cmp = memcmp(name, (xs->base +
--                                   le16_to_cpu(entry->xe_name_offset)),
--                                   name_len);
-+              if (!cmp) {
-+                      name_offset = le16_to_cpu(entry->xe_name_offset);
-+                      if ((xs->base + name_offset + name_len) > xs->end) {
-+                              ocfs2_error(inode->i_sb,
-+                                          "corrupted xattr entries");
-+                              return -EFSCORRUPTED;
-+                      }
-+                      cmp = memcmp(name, (xs->base + name_offset), name_len);
-+              }
-               if (cmp == 0)
-                       break;
-               entry += 1;
index 53281433b5ddb3ecfbbeaaf0ae1df24bb98ddb43..e69de29bb2d1d6434b8b29ae775ad8c2e48c5391 100644 (file)
@@ -1 +0,0 @@
-ocfs2-strict-bound-check-before-memcmp-in-ocfs2_xattr_find_entry.patch