]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
wifi: ath12k: ath12k_mac_vdev_create(): use goto for error handling
authorKalle Valo <quic_kvalo@quicinc.com>
Fri, 1 Nov 2024 15:16:58 +0000 (17:16 +0200)
committerJeff Johnson <quic_jjohnson@quicinc.com>
Wed, 6 Nov 2024 19:36:28 +0000 (11:36 -0800)
In commit 477cabfdb776 ("wifi: ath12k: modify link arvif creation and removal
for MLO") I had accidentally left one personal TODO comment about using goto
instead of ret. Switch to use goto to be consistent with the error handling in
the function.

Tested-on: WCN7850 hw2.0 PCI WLAN.HMT.1.0.c5-00481-QCAHMTSWPL_V1.0_V2.0_SILICONZ-3

Signed-off-by: Kalle Valo <quic_kvalo@quicinc.com>
Acked-by: Jeff Johnson <quic_jjohnson@quicinc.com>
Link: https://patch.msgid.link/20241101151705.165987-2-kvalo@kernel.org
Signed-off-by: Jeff Johnson <quic_jjohnson@quicinc.com>
drivers/net/wireless/ath/ath12k/mac.c

index d493ec812055f8e2baa0da86350ee704dae72ba2..fa48200f012e858ca57ecb9dfacdde0ec0f3356e 100644 (file)
@@ -7034,8 +7034,7 @@ err_peer_del:
                ret = ath12k_wait_for_peer_delete_done(ar, arvif->vdev_id,
                                                       arvif->bssid);
                if (ret)
-                       /* KVALO: why not goto err? */
-                       return ret;
+                       goto err_vdev_del;
 
                ar->num_peers--;
        }