xfs_fsr: check strdup results properly in initallfs()

initallfs() does 2 strdups, but then checks the result
of one of them twice, rather then checking each one.
Fix this.

Signed-off-by: Eric Sandeen <sandeen@redhat.com>
Reviewed-by: Mark Tinguely <tinguely@sgi.com>
Signed-off-by: Mark Tinguely <tinguely@sgi.com>

diff --git a/fsr/xfs_fsr.c b/fsr/xfs_fsr.c
index 843f57d707669334bfa756be765abd8dcfa415e5..b5aa3db76f751b018080fc5512ca258e8f7fad21 100644 (file)
--- a/fsr/xfs_fsr.c
+++ b/fsr/xfs_fsr.c
@@ -470,10 +470,14 @@ initallfs(char *mtab)
                fs->dev = strdup(mp->mnt_fsname);
                fs->mnt = strdup(mp->mnt_dir);
 
-               if (fs->mnt == NULL || fs->mnt == NULL) {
+               if (fs->dev == NULL) {
                        fsrprintf(_("strdup(%s) failed\n"), mp->mnt_fsname);
                        exit(1);
                }
+               if (fs->mnt == NULL) {
+                       fsrprintf(_("strdup(%s) failed\n"), mp->mnt_dir);
+                       exit(1);
+               }
                mi++;
                fs++;
        }