* src/chsh.c: No needto remove lines tarting with '#' from

	/etc/shells. This is already done by getusershell() and these
	shell would fail the access(X_OK) test.

diff --git a/ChangeLog b/ChangeLog
index 9ad939a650f3f86c9482f2bd36c34e8db7249fae..c7139c387bf892a3b2f4cdafffb41f3f3891f998 100644 (file)
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,9 @@
+2011-09-18  Nicolas François  <nicolas.francois@centraliens.net>
+
+       * src/chsh.c: No needto remove lines tarting with '#' from
+       /etc/shells. This is already done by getusershell() and these
+       shell would fail the access(X_OK) test.
+
 2011-09-18  Nicolas François  <nicolas.francois@centraliens.net>
 
        * man/generate_mans.mak: Fix the generation of translated man

diff --git a/src/chsh.c b/src/chsh.c
index 553fe5c3b85cc2e781c33c1ad52febbe6856a45e..a2e8fe7f974451d1d4af241ed9f0d39a7f4d9cfd 100644 (file)
--- a/src/chsh.c
+++ b/src/chsh.c
@@ -2,7 +2,7 @@
  * Copyright (c) 1989 - 1994, Julianne Frances Haugh
  * Copyright (c) 1996 - 2000, Marek Michałkiewicz
  * Copyright (c) 2001 - 2006, Tomasz Kłoczko
- * Copyright (c) 2007 - 2008, Nicolas François
+ * Copyright (c) 2007 - 2011, Nicolas François
  * All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
@@ -161,10 +161,6 @@ static bool shell_is_listed (const char *sh)
 #ifdef HAVE_GETUSERSHELL
        setusershell ();
        while ((cp = getusershell ())) {
-               if (*cp == '#') {
-                       continue;
-               }
-
                if (strcmp (cp, sh) == 0) {
                        found = true;
                        break;