mtd: ubi: Remove test that always fails

When checking the VID header of a static volume there is an early test
for data_size == 0 so testing for that condition again is guaranteed to
fail. Just remove this piece of code.

This issue was found by Smatch.

Signed-off-by: Andrew Goodbody <andrew.goodbody@linaro.org>

diff --git a/drivers/mtd/ubi/io.c b/drivers/mtd/ubi/io.c
index 45699b4a4778d92f573426c63fcc1c06e0b911c2..2ec968c85ffd9cfff14b27c2d8a6fea1e9b63372 100644 (file)
--- a/drivers/mtd/ubi/io.c
+++ b/drivers/mtd/ubi/io.c
@@ -936,12 +936,7 @@ static int validate_vid_hdr(const struct ubi_device *ubi,
                                ubi_err(ubi, "bad data_size");
                                goto bad;
                        }
-               } else if (lnum == used_ebs - 1) {
-                       if (data_size == 0) {
-                               ubi_err(ubi, "bad data_size at last LEB");
-                               goto bad;
-                       }
-               } else {
+               } else if (lnum != used_ebs - 1) {
                        ubi_err(ubi, "too high lnum");
                        goto bad;
                }