]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
net: ti: icssg-prueth: Fix kernel warning while bringing down network interface
authorMeghana Malladi <m-malladi@ti.com>
Tue, 15 Apr 2025 09:05:41 +0000 (14:35 +0530)
committerPaolo Abeni <pabeni@redhat.com>
Thu, 17 Apr 2025 10:11:24 +0000 (12:11 +0200)
During network interface initialization, the NIC driver needs to register
its Rx queue with the XDP, to ensure the incoming XDP buffer carries a
pointer reference to this info and is stored inside xdp_rxq_info.

While this struct isn't tied to XDP prog, if there are any changes in
Rx queue, the NIC driver needs to stop the Rx queue by unregistering
with XDP before purging and reallocating memory. Drop page_pool destroy
during Rx channel reset as this is already handled by XDP during
xdp_rxq_info_unreg (Rx queue unregister), failing to do will cause the
following warning:

warning logs: https://gist.github.com/MeghanaMalladiTI/eb627e5dc8de24e42d7d46572c13e576

Fixes: 46eeb90f03e0 ("net: ti: icssg-prueth: Use page_pool API for RX buffer allocation")
Signed-off-by: Meghana Malladi <m-malladi@ti.com>
Reviewed-by: Simon Horman <horms@kernel.org>
Reviewed-by: Roger Quadros <rogerq@kernel.org>
Reviewed-by: Jacob Keller <jacob.e.keller@intel.com>
Link: https://patch.msgid.link/20250415090543.717991-2-m-malladi@ti.com
Signed-off-by: Paolo Abeni <pabeni@redhat.com>
drivers/net/ethernet/ti/icssg/icssg_common.c

index 14002b0264528cb87b6435c2fb3b0bf9b4c6dd14..ec643fb69d30d8afe1d565a07159f0c812e81419 100644 (file)
@@ -1215,9 +1215,6 @@ void prueth_reset_rx_chan(struct prueth_rx_chn *chn,
                                          prueth_rx_cleanup);
        if (disable)
                k3_udma_glue_disable_rx_chn(chn->rx_chn);
-
-       page_pool_destroy(chn->pg_pool);
-       chn->pg_pool = NULL;
 }
 EXPORT_SYMBOL_GPL(prueth_reset_rx_chan);