]> git.ipfire.org Git - thirdparty/libvirt.git/commitdiff
domain_conf: fix domain deadlock
authorPavel Hrdina <phrdina@redhat.com>
Mon, 22 Sep 2014 16:19:07 +0000 (18:19 +0200)
committerEric Blake <eblake@redhat.com>
Wed, 1 Oct 2014 17:41:27 +0000 (11:41 -0600)
If you use public api virConnectListAllDomains() with second parameter
set to NULL to get only the number of domains you will lock out all
other operations with domains.

Introduced by commit 2c680804.

Signed-off-by: Pavel Hrdina <phrdina@redhat.com>
(cherry picked from commit fc22b2e74890873848b43fffae43025d22053669)

src/conf/domain_conf.c

index 6365fb45fb110e9dd90335ad1af9cef377efa4b3..0608d145b69abccc45049da7c4492e5e3ef6e9f4 100644 (file)
@@ -18274,7 +18274,7 @@ virDomainListPopulate(void *payload,
     /* just count the machines */
     if (!data->domains) {
         data->ndomains++;
-        return;
+        goto cleanup;
     }
 
     if (!(dom = virGetDomain(data->conn, vm->def->name, vm->def->uuid))) {